Skip to content

Commit c8c59bc

Browse files
robherringmmind
authored andcommitted
arm64: dts: rockchip: Use "regulator-fixed" for btreg on px30-engicam for vcc3v3-btreg
The vcc3v3-btreg regulator only has 1 state and no state gpios defined, so "regulator-gpio" is not the correct binding to use. "regulator-fixed" is the correct binding to use. It supports an enable GPIO which is needed in this case. Signed-off-by: "Rob Herring (Arm)" <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 7fc027e commit c8c59bc

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

arch/arm64/boot/dts/rockchip/px30-engicam-common.dtsi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,14 @@
3131
};
3232

3333
vcc3v3_btreg: vcc3v3-btreg {
34-
compatible = "regulator-gpio";
34+
compatible = "regulator-fixed";
3535
enable-active-high;
3636
pinctrl-names = "default";
3737
pinctrl-0 = <&bt_enable_h>;
3838
regulator-name = "btreg-gpio-supply";
3939
regulator-min-microvolt = <3300000>;
4040
regulator-max-microvolt = <3300000>;
4141
regulator-always-on;
42-
states = <3300000 0x0>;
4342
};
4443

4544
vcc3v3_rf_aux_mod: regulator-vcc3v3-rf-aux-mod {

arch/arm64/boot/dts/rockchip/px30-engicam-ctouch2.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@
2626
};
2727

2828
&vcc3v3_btreg {
29-
enable-gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
29+
gpios = <&gpio1 RK_PC3 GPIO_ACTIVE_HIGH>;
3030
};

arch/arm64/boot/dts/rockchip/px30-engicam-px30-core-edimm2.2.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@
3939
};
4040

4141
&vcc3v3_btreg {
42-
enable-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
42+
gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
4343
};

0 commit comments

Comments
 (0)