Skip to content

Commit c8dce4e

Browse files
kadesai16jgunthorpe
authored andcommitted
RDMA/bnxt_re: Remove incorrect return check from slow path
The commit 691eb7c ("RDMA/bnxt_re: handle command completions after driver detect a timedout") introduced code resulting in below warning issued by the smatch static checker. drivers/infiniband/hw/bnxt_re/qplib_rcfw.c:513 __bnxt_qplib_rcfw_send_message() warn: duplicate check 'rc' (previous on line 506) Fix the warning by removing incorrect code block. Fixes: 691eb7c ("RDMA/bnxt_re: handle command completions after driver detect a timedout") Link: https://lore.kernel.org/r/[email protected] Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Kashyap Desai <[email protected]> Signed-off-by: Selvin Xavier <[email protected]> Signed-off-by: Jason Gunthorpe <[email protected]>
1 parent 360da60 commit c8dce4e

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/infiniband/hw/bnxt_re/qplib_rcfw.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -502,12 +502,6 @@ static int __bnxt_qplib_rcfw_send_message(struct bnxt_qplib_rcfw *rcfw,
502502
rc = __wait_for_resp(rcfw, cookie);
503503
else
504504
rc = __poll_for_resp(rcfw, cookie);
505-
if (rc) {
506-
/* timed out */
507-
dev_err(&rcfw->pdev->dev, "cmdq[%#x]=%#x timedout (%d)msec\n",
508-
cookie, opcode, RCFW_CMD_WAIT_TIME_MS);
509-
return rc;
510-
}
511505

512506
if (rc) {
513507
spin_lock_irqsave(&rcfw->cmdq.hwq.lock, flags);

0 commit comments

Comments
 (0)