Skip to content

Commit c8fee6a

Browse files
tdzhdeller
authored andcommitted
fbdev: Make drivers depend on LCD_CLASS_DEVICE
LCD_CLASS_DEVICE is the user-controlled option that enables the LCD display subsystem. Do not select it from fbdev drivers. Selecting it from drivers can lead to cyclic dependencies within the config. Some guidelines for using select can be found in the kernel docs at [1]. Signed-off-by: Thomas Zimmermann <[email protected]> Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147 # [1] Signed-off-by: Helge Deller <[email protected]>
1 parent c3073f1 commit c8fee6a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/video/fbdev/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,9 @@ config FB_ACORN
126126
config FB_CLPS711X
127127
tristate "CLPS711X LCD support"
128128
depends on FB && (ARCH_CLPS711X || COMPILE_TEST)
129+
depends on LCD_CLASS_DEVICE
129130
select FB_IOMEM_HELPERS
130131
select FB_MODE_HELPERS
131-
select LCD_CLASS_DEVICE
132132
select VIDEOMODE_HELPERS
133133
help
134134
Say Y to enable the Framebuffer driver for the Cirrus Logic
@@ -150,7 +150,7 @@ config FB_IMX
150150
tristate "Freescale i.MX1/21/25/27 LCD support"
151151
depends on FB && HAVE_CLK && HAS_IOMEM
152152
depends on ARCH_MXC || COMPILE_TEST
153-
select LCD_CLASS_DEVICE
153+
depends on LCD_CLASS_DEVICE
154154
select FB_IOMEM_HELPERS
155155
select FB_MODE_HELPERS
156156
select VIDEOMODE_HELPERS

0 commit comments

Comments
 (0)