Skip to content

Commit c90521a

Browse files
cris-masudeep-holla
authored andcommitted
firmware: arm_scmi: Fix virtio transport Kconfig dependency
ARM_SCMI_TRANSPORT_VIRTIO is a 'bool' Kconfig used to include support for the SCMI virtio transport inside the core SCMI stack; a bare transport dependency attached here to this option, though, cannot be properly propagated to the parent ARM_SCMI_PROTOCOL option and, as a result, it is currently possible to configure a Kernel where SCMI core is builtin and includes support for virtio while VirtIO core is =m. This allowed combination breaks linking: ARM_SCMI_PROTOCOL=y ARM_SCMI_TRANSPORT_VIRTIO=y VIRTIO=m Bind the dependency in ARM_SCMI_TRANSPORT_VIRTIO to the chosen kind of compilation of ARM_SCMI_PROTOCOL. Link: https://lore.kernel.org/r/[email protected] Fixes: 46abe13 ("firmware: arm_scmi: Add virtio transport") Reported-by: kernel test robot <[email protected]> Suggested-by: Arnd Bergmann <[email protected]> Acked-by: Arnd Bergmann <[email protected]> Signed-off-by: Cristian Marussi <[email protected]> Signed-off-by: Sudeep Holla <[email protected]>
1 parent 6880fa6 commit c90521a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/firmware/arm_scmi/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC
6868

6969
config ARM_SCMI_TRANSPORT_VIRTIO
7070
bool "SCMI transport based on VirtIO"
71-
depends on VIRTIO
71+
depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL
7272
select ARM_SCMI_HAVE_TRANSPORT
7373
select ARM_SCMI_HAVE_MSG
7474
help

0 commit comments

Comments
 (0)