block, bfq: clarify the goal of bfq_split_bfqq()

Algodev-github · axboe · commit c92bddee7735 · 2020-02-03T06:58:15.000-07:00
The exact, general goal of the function bfq_split_bfqq() is not that
apparent. Add a comment to make it clear.

Tested-by: Oleksandr Natalenko &lt;oleksandr@natalenko.name&gt;
Signed-off-by: Paolo Valente &lt;paolo.valente@linaro.org&gt;
Signed-off-by: Jens Axboe &lt;axboe@kernel.dk&gt;
diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
@@ -5979,6 +5979,8 @@ static void bfq_finish_requeue_request(struct request *rq)
 }
 
 /*
+ * Removes the association between the current task and bfqq, assuming
+ * that bic points to the bfq iocontext of the task.
  * Returns NULL if a new bfqq should be allocated, or the old bfqq if this
  * was the last process referring to that bfqq.
  */

Original file line number	Diff line number	Diff line change
`@@ -5979,6 +5979,8 @@ static void bfq_finish_requeue_request(struct request *rq)`
`5979`	`5979`	`}`
`5980`	`5980`
`5981`	`5981`	`/*`
	`5982`	`+ * Removes the association between the current task and bfqq, assuming`
	`5983`	`+ * that bic points to the bfq iocontext of the task.`
`5982`	`5984`	`* Returns NULL if a new bfqq should be allocated, or the old bfqq if this`
`5983`	`5985`	`* was the last process referring to that bfqq.`
`5984`	`5986`	`*/`