Skip to content

Commit c9b48b9

Browse files
Yuan Candianders
authored andcommitted
drm/panel: simple: Use dev_err_probe() to simplify code
In the probe path, dev_err() can be replaced with dev_err_probe() which will check if error code is -EPROBE_DEFER and prints the error name. It also sets the defer probe reason which can be checked later through debugfs. Signed-off-by: Yuan Can <[email protected]> Reviewed-by: Douglas Anderson <[email protected]> Signed-off-by: Douglas Anderson <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent b28d204 commit c9b48b9

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/gpu/drm/panel/panel-simple.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -575,12 +575,9 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
575575

576576
panel->enable_gpio = devm_gpiod_get_optional(dev, "enable",
577577
GPIOD_OUT_LOW);
578-
if (IS_ERR(panel->enable_gpio)) {
579-
err = PTR_ERR(panel->enable_gpio);
580-
if (err != -EPROBE_DEFER)
581-
dev_err(dev, "failed to request GPIO: %d\n", err);
582-
return err;
583-
}
578+
if (IS_ERR(panel->enable_gpio))
579+
return dev_err_probe(dev, PTR_ERR(panel->enable_gpio),
580+
"failed to request GPIO\n");
584581

585582
err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation);
586583
if (err) {

0 commit comments

Comments
 (0)