Skip to content

Commit ca16cb2

Browse files
tititiou36nmenon
authored andcommitted
soc: ti: knav_qmss: Constify struct knav_range_ops
'struct knav_range_ops' is not modified in these drivers. Constifying this structure moves some data to a read-only section, so increase overall security. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 7498 1193 0 8691 21f3 drivers/soc/ti/knav_qmss_acc.o After: ===== text data bss dec hex filename 7566 1145 0 8711 2207 drivers/soc/ti/knav_qmss_acc.o Signed-off-by: Christophe JAILLET <[email protected]> Link: https://lore.kernel.org/r/a8b4b428f97fc584f38bf45100aa9da241aeb935.1719159074.git.christophe.jaillet@wanadoo.fr Signed-off-by: Nishanth Menon <[email protected]>
1 parent f1de10a commit ca16cb2

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

drivers/soc/ti/knav_qmss.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ struct knav_range_info {
333333
void *queue_base_inst;
334334
unsigned flags;
335335
struct list_head list;
336-
struct knav_range_ops *ops;
336+
const struct knav_range_ops *ops;
337337
struct knav_acc_info acc_info;
338338
struct knav_acc_channel *acc;
339339
unsigned num_irqs;

drivers/soc/ti/knav_qmss_acc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ static int knav_acc_free_range(struct knav_range_info *range)
450450
return 0;
451451
}
452452

453-
static struct knav_range_ops knav_acc_range_ops = {
453+
static const struct knav_range_ops knav_acc_range_ops = {
454454
.set_notify = knav_acc_set_notify,
455455
.init_queue = knav_acc_init_queue,
456456
.open_queue = knav_acc_open_queue,

drivers/soc/ti/knav_qmss_queue.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ static int knav_gp_close_queue(struct knav_range_info *range,
411411
return 0;
412412
}
413413

414-
static struct knav_range_ops knav_gp_range_ops = {
414+
static const struct knav_range_ops knav_gp_range_ops = {
415415
.set_notify = knav_gp_set_notify,
416416
.open_queue = knav_gp_open_queue,
417417
.close_queue = knav_gp_close_queue,

0 commit comments

Comments
 (0)