Skip to content

Commit ca43b74

Browse files
Darrick J. Wongcmaiolino
authored andcommitted
xfs: remove some EXPERIMENTAL warnings
Online fsck was finished a year ago, in Linux 6.10. The exchange-range syscall and parent pointers were merged in the same cycle. None of these have encountered any serious errors in the year that they've been in the kernel (or the many many years they've been under development) so let's drop the shouty warnings. Signed-off-by: Darrick J. Wong <[email protected]> Reviewed-by: Dave Chinner <[email protected]> Reviewed-by: Carlos Maiolino <[email protected]> Signed-off-by: Carlos Maiolino <[email protected]>
1 parent 6e7d71b commit ca43b74

File tree

5 files changed

+0
-31
lines changed

5 files changed

+0
-31
lines changed

fs/xfs/scrub/scrub.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,6 @@ xfs_scrub_metadata(
680680
if (error)
681681
goto out;
682682

683-
xfs_warn_experimental(mp, XFS_EXPERIMENTAL_SCRUB);
684-
685683
sc = kzalloc(sizeof(struct xfs_scrub), XCHK_GFP_FLAGS);
686684
if (!sc) {
687685
error = -ENOMEM;

fs/xfs/xfs_message.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,6 @@ xfs_warn_experimental(
145145
.opstate = XFS_OPSTATE_WARNED_PNFS,
146146
.name = "pNFS",
147147
},
148-
[XFS_EXPERIMENTAL_SCRUB] = {
149-
.opstate = XFS_OPSTATE_WARNED_SCRUB,
150-
.name = "online scrub",
151-
},
152148
[XFS_EXPERIMENTAL_SHRINK] = {
153149
.opstate = XFS_OPSTATE_WARNED_SHRINK,
154150
.name = "online shrink",
@@ -161,14 +157,6 @@ xfs_warn_experimental(
161157
.opstate = XFS_OPSTATE_WARNED_LBS,
162158
.name = "large block size",
163159
},
164-
[XFS_EXPERIMENTAL_EXCHRANGE] = {
165-
.opstate = XFS_OPSTATE_WARNED_EXCHRANGE,
166-
.name = "exchange range",
167-
},
168-
[XFS_EXPERIMENTAL_PPTR] = {
169-
.opstate = XFS_OPSTATE_WARNED_PPTR,
170-
.name = "parent pointer",
171-
},
172160
[XFS_EXPERIMENTAL_METADIR] = {
173161
.opstate = XFS_OPSTATE_WARNED_METADIR,
174162
.name = "metadata directory tree",

fs/xfs/xfs_message.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg,
9292

9393
enum xfs_experimental_feat {
9494
XFS_EXPERIMENTAL_PNFS,
95-
XFS_EXPERIMENTAL_SCRUB,
9695
XFS_EXPERIMENTAL_SHRINK,
9796
XFS_EXPERIMENTAL_LARP,
9897
XFS_EXPERIMENTAL_LBS,
99-
XFS_EXPERIMENTAL_EXCHRANGE,
100-
XFS_EXPERIMENTAL_PPTR,
10198
XFS_EXPERIMENTAL_METADIR,
10299
XFS_EXPERIMENTAL_ZONED,
103100

fs/xfs/xfs_mount.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -559,8 +559,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
559559

560560
/* Kernel has logged a warning about pNFS being used on this fs. */
561561
#define XFS_OPSTATE_WARNED_PNFS 7
562-
/* Kernel has logged a warning about online fsck being used on this fs. */
563-
#define XFS_OPSTATE_WARNED_SCRUB 8
564562
/* Kernel has logged a warning about shrink being used on this fs. */
565563
#define XFS_OPSTATE_WARNED_SHRINK 9
566564
/* Kernel has logged a warning about logged xattr updates being used. */
@@ -573,10 +571,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID)
573571
#define XFS_OPSTATE_USE_LARP 13
574572
/* Kernel has logged a warning about blocksize > pagesize on this fs. */
575573
#define XFS_OPSTATE_WARNED_LBS 14
576-
/* Kernel has logged a warning about exchange-range being used on this fs. */
577-
#define XFS_OPSTATE_WARNED_EXCHRANGE 15
578-
/* Kernel has logged a warning about parent pointers being used on this fs. */
579-
#define XFS_OPSTATE_WARNED_PPTR 16
580574
/* Kernel has logged a warning about metadata dirs being used on this fs. */
581575
#define XFS_OPSTATE_WARNED_METADIR 17
582576
/* Filesystem should use qflags to determine quotaon status */
@@ -645,7 +639,6 @@ xfs_should_warn(struct xfs_mount *mp, long nr)
645639
{ (1UL << XFS_OPSTATE_READONLY), "read_only" }, \
646640
{ (1UL << XFS_OPSTATE_INODEGC_ENABLED), "inodegc" }, \
647641
{ (1UL << XFS_OPSTATE_BLOCKGC_ENABLED), "blockgc" }, \
648-
{ (1UL << XFS_OPSTATE_WARNED_SCRUB), "wscrub" }, \
649642
{ (1UL << XFS_OPSTATE_WARNED_SHRINK), "wshrink" }, \
650643
{ (1UL << XFS_OPSTATE_WARNED_LARP), "wlarp" }, \
651644
{ (1UL << XFS_OPSTATE_QUOTACHECK_RUNNING), "quotacheck" }, \

fs/xfs/xfs_super.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1954,13 +1954,6 @@ xfs_fs_fill_super(
19541954
}
19551955
}
19561956

1957-
1958-
if (xfs_has_exchange_range(mp))
1959-
xfs_warn_experimental(mp, XFS_EXPERIMENTAL_EXCHRANGE);
1960-
1961-
if (xfs_has_parent(mp))
1962-
xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PPTR);
1963-
19641957
/*
19651958
* If no quota mount options were provided, maybe we'll try to pick
19661959
* up the quota accounting and enforcement flags from the ondisk sb.

0 commit comments

Comments
 (0)