Skip to content

Commit ca98d72

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix incorrect return value in f2fs_sanity_check_ckpt()
As Pavel Machek reported in [1] This code looks quite confused: part of function returns 1 on corruption, part returns -errno. The problem is not stable-specific. [1] https://lkml.org/lkml/2021/9/19/207 Let's fix to make 'insane cp_payload case' to return 1 rater than EFSCORRUPTED, so that return value can be kept consistent for all error cases, it can avoid confusion of code logic. Fixes: 65ddf65 ("f2fs: fix to do sanity check for sb/cp fields correctly") Reported-by: Pavel Machek <[email protected]> Reviewed-by: Pavel Machek <[email protected]> Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 02d58cd commit ca98d72

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/f2fs/super.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3495,7 +3495,7 @@ int f2fs_sanity_check_ckpt(struct f2fs_sb_info *sbi)
34953495
NR_CURSEG_PERSIST_TYPE + nat_bits_blocks >= blocks_per_seg)) {
34963496
f2fs_warn(sbi, "Insane cp_payload: %u, nat_bits_blocks: %u)",
34973497
cp_payload, nat_bits_blocks);
3498-
return -EFSCORRUPTED;
3498+
return 1;
34993499
}
35003500

35013501
if (unlikely(f2fs_cp_error(sbi))) {

0 commit comments

Comments
 (0)