Skip to content

Commit caab314

Browse files
committed
Merge branch 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
Pull i2c fixes from Wolfram Sang: "Three driver bugfixes for I2C. Buisness as usual" * 'i2c/for-current' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux: i2c: mediatek: Fix apdma and i2c hand-shake timeout i2c: i801: Fix the i2c-mux gpiod_lookup_table not being properly terminated i2c: sprd: use a specific timeout to avoid system hang up issue
2 parents 6bae85b + 05f6f72 commit caab314

File tree

3 files changed

+30
-7
lines changed

3 files changed

+30
-7
lines changed

drivers/i2c/busses/i2c-i801.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1449,7 +1449,7 @@ static int i801_add_mux(struct i801_priv *priv)
14491449

14501450
/* Register GPIO descriptor lookup table */
14511451
lookup = devm_kzalloc(dev,
1452-
struct_size(lookup, table, mux_config->n_gpios),
1452+
struct_size(lookup, table, mux_config->n_gpios + 1),
14531453
GFP_KERNEL);
14541454
if (!lookup)
14551455
return -ENOMEM;

drivers/i2c/busses/i2c-mt65xx.c

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,15 @@
3838
#define I2C_IO_CONFIG_OPEN_DRAIN 0x0003
3939
#define I2C_IO_CONFIG_PUSH_PULL 0x0000
4040
#define I2C_SOFT_RST 0x0001
41+
#define I2C_HANDSHAKE_RST 0x0020
4142
#define I2C_FIFO_ADDR_CLR 0x0001
4243
#define I2C_DELAY_LEN 0x0002
4344
#define I2C_TIME_CLR_VALUE 0x0000
4445
#define I2C_TIME_DEFAULT_VALUE 0x0003
4546
#define I2C_WRRD_TRANAC_VALUE 0x0002
4647
#define I2C_RD_TRANAC_VALUE 0x0001
4748
#define I2C_SCL_MIS_COMP_VALUE 0x0000
49+
#define I2C_CHN_CLR_FLAG 0x0000
4850

4951
#define I2C_DMA_CON_TX 0x0000
5052
#define I2C_DMA_CON_RX 0x0001
@@ -54,7 +56,9 @@
5456
#define I2C_DMA_START_EN 0x0001
5557
#define I2C_DMA_INT_FLAG_NONE 0x0000
5658
#define I2C_DMA_CLR_FLAG 0x0000
59+
#define I2C_DMA_WARM_RST 0x0001
5760
#define I2C_DMA_HARD_RST 0x0002
61+
#define I2C_DMA_HANDSHAKE_RST 0x0004
5862

5963
#define MAX_SAMPLE_CNT_DIV 8
6064
#define MAX_STEP_CNT_DIV 64
@@ -475,11 +479,24 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
475479
{
476480
u16 control_reg;
477481

478-
writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
479-
udelay(50);
480-
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
481-
482-
mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
482+
if (i2c->dev_comp->dma_sync) {
483+
writel(I2C_DMA_WARM_RST, i2c->pdmabase + OFFSET_RST);
484+
udelay(10);
485+
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
486+
udelay(10);
487+
writel(I2C_DMA_HANDSHAKE_RST | I2C_DMA_HARD_RST,
488+
i2c->pdmabase + OFFSET_RST);
489+
mtk_i2c_writew(i2c, I2C_HANDSHAKE_RST | I2C_SOFT_RST,
490+
OFFSET_SOFTRESET);
491+
udelay(10);
492+
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
493+
mtk_i2c_writew(i2c, I2C_CHN_CLR_FLAG, OFFSET_SOFTRESET);
494+
} else {
495+
writel(I2C_DMA_HARD_RST, i2c->pdmabase + OFFSET_RST);
496+
udelay(50);
497+
writel(I2C_DMA_CLR_FLAG, i2c->pdmabase + OFFSET_RST);
498+
mtk_i2c_writew(i2c, I2C_SOFT_RST, OFFSET_SOFTRESET);
499+
}
483500

484501
/* Set ioconfig */
485502
if (i2c->use_push_pull)

drivers/i2c/busses/i2c-sprd.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@
7272

7373
/* timeout (ms) for pm runtime autosuspend */
7474
#define SPRD_I2C_PM_TIMEOUT 1000
75+
/* timeout (ms) for transfer message */
76+
#define I2C_XFER_TIMEOUT 1000
7577

7678
/* SPRD i2c data structure */
7779
struct sprd_i2c {
@@ -244,6 +246,7 @@ static int sprd_i2c_handle_msg(struct i2c_adapter *i2c_adap,
244246
struct i2c_msg *msg, bool is_last_msg)
245247
{
246248
struct sprd_i2c *i2c_dev = i2c_adap->algo_data;
249+
unsigned long time_left;
247250

248251
i2c_dev->msg = msg;
249252
i2c_dev->buf = msg->buf;
@@ -273,7 +276,10 @@ static int sprd_i2c_handle_msg(struct i2c_adapter *i2c_adap,
273276

274277
sprd_i2c_opt_start(i2c_dev);
275278

276-
wait_for_completion(&i2c_dev->complete);
279+
time_left = wait_for_completion_timeout(&i2c_dev->complete,
280+
msecs_to_jiffies(I2C_XFER_TIMEOUT));
281+
if (!time_left)
282+
return -ETIMEDOUT;
277283

278284
return i2c_dev->err;
279285
}

0 commit comments

Comments
 (0)