Skip to content

Commit cae932d

Browse files
committed
netfs: Add func to calculate pagecount/size-limited span of an iterator
Add a function to work out how much of an ITER_BVEC or ITER_XARRAY iterator we can use in a pagecount-limited and size-limited span. This will be used, for example, to limit the number of segments in a subrequest to the maximum number of elements that an RDMA transfer can handle. Signed-off-by: David Howells <[email protected]> Reviewed-by: Jeff Layton <[email protected]> cc: [email protected] cc: [email protected] cc: [email protected]
1 parent 7d828a0 commit cae932d

File tree

2 files changed

+99
-0
lines changed

2 files changed

+99
-0
lines changed

fs/netfs/iterator.c

Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,3 +101,100 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,
101101
return npages;
102102
}
103103
EXPORT_SYMBOL_GPL(netfs_extract_user_iter);
104+
105+
/*
106+
* Select the span of a bvec iterator we're going to use. Limit it by both maximum
107+
* size and maximum number of segments. Returns the size of the span in bytes.
108+
*/
109+
static size_t netfs_limit_bvec(const struct iov_iter *iter, size_t start_offset,
110+
size_t max_size, size_t max_segs)
111+
{
112+
const struct bio_vec *bvecs = iter->bvec;
113+
unsigned int nbv = iter->nr_segs, ix = 0, nsegs = 0;
114+
size_t len, span = 0, n = iter->count;
115+
size_t skip = iter->iov_offset + start_offset;
116+
117+
if (WARN_ON(!iov_iter_is_bvec(iter)) ||
118+
WARN_ON(start_offset > n) ||
119+
n == 0)
120+
return 0;
121+
122+
while (n && ix < nbv && skip) {
123+
len = bvecs[ix].bv_len;
124+
if (skip < len)
125+
break;
126+
skip -= len;
127+
n -= len;
128+
ix++;
129+
}
130+
131+
while (n && ix < nbv) {
132+
len = min3(n, bvecs[ix].bv_len - skip, max_size);
133+
span += len;
134+
nsegs++;
135+
ix++;
136+
if (span >= max_size || nsegs >= max_segs)
137+
break;
138+
skip = 0;
139+
n -= len;
140+
}
141+
142+
return min(span, max_size);
143+
}
144+
145+
/*
146+
* Select the span of an xarray iterator we're going to use. Limit it by both
147+
* maximum size and maximum number of segments. It is assumed that segments
148+
* can be larger than a page in size, provided they're physically contiguous.
149+
* Returns the size of the span in bytes.
150+
*/
151+
static size_t netfs_limit_xarray(const struct iov_iter *iter, size_t start_offset,
152+
size_t max_size, size_t max_segs)
153+
{
154+
struct folio *folio;
155+
unsigned int nsegs = 0;
156+
loff_t pos = iter->xarray_start + iter->iov_offset;
157+
pgoff_t index = pos / PAGE_SIZE;
158+
size_t span = 0, n = iter->count;
159+
160+
XA_STATE(xas, iter->xarray, index);
161+
162+
if (WARN_ON(!iov_iter_is_xarray(iter)) ||
163+
WARN_ON(start_offset > n) ||
164+
n == 0)
165+
return 0;
166+
max_size = min(max_size, n - start_offset);
167+
168+
rcu_read_lock();
169+
xas_for_each(&xas, folio, ULONG_MAX) {
170+
size_t offset, flen, len;
171+
if (xas_retry(&xas, folio))
172+
continue;
173+
if (WARN_ON(xa_is_value(folio)))
174+
break;
175+
if (WARN_ON(folio_test_hugetlb(folio)))
176+
break;
177+
178+
flen = folio_size(folio);
179+
offset = offset_in_folio(folio, pos);
180+
len = min(max_size, flen - offset);
181+
span += len;
182+
nsegs++;
183+
if (span >= max_size || nsegs >= max_segs)
184+
break;
185+
}
186+
187+
rcu_read_unlock();
188+
return min(span, max_size);
189+
}
190+
191+
size_t netfs_limit_iter(const struct iov_iter *iter, size_t start_offset,
192+
size_t max_size, size_t max_segs)
193+
{
194+
if (iov_iter_is_bvec(iter))
195+
return netfs_limit_bvec(iter, start_offset, max_size, max_segs);
196+
if (iov_iter_is_xarray(iter))
197+
return netfs_limit_xarray(iter, start_offset, max_size, max_segs);
198+
BUG();
199+
}
200+
EXPORT_SYMBOL(netfs_limit_iter);

include/linux/netfs.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ void netfs_put_subrequest(struct netfs_io_subrequest *subreq,
321321
ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,
322322
struct iov_iter *new,
323323
iov_iter_extraction_t extraction_flags);
324+
size_t netfs_limit_iter(const struct iov_iter *iter, size_t start_offset,
325+
size_t max_size, size_t max_segs);
324326

325327
int netfs_start_io_read(struct inode *inode);
326328
void netfs_end_io_read(struct inode *inode);

0 commit comments

Comments
 (0)