Skip to content

Commit cb2e701

Browse files
ckborahjlahtine-intel
authored andcommitted
drm/i915/display: Set correct voltage level for 480MHz CDCLK
According to Bspec, the voltage level for 480MHz is to be set as 1 instead of 2. BSpec: 49208 Fixes: 06f1b06 ("drm/i915/display: Add 480 MHz CDCLK steps for RPL-U") v2: rebase Signed-off-by: Chaitanya Kumar Borah <[email protected]> Reviewed-by: Mika Kahola <[email protected]> Signed-off-by: Matt Roper <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 5a3c46b) Signed-off-by: Joonas Lahtinen <[email protected]>
1 parent 4002395 commit cb2e701

File tree

1 file changed

+26
-4
lines changed

1 file changed

+26
-4
lines changed

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 26 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1453,6 +1453,18 @@ static u8 tgl_calc_voltage_level(int cdclk)
14531453
return 0;
14541454
}
14551455

1456+
static u8 rplu_calc_voltage_level(int cdclk)
1457+
{
1458+
if (cdclk > 556800)
1459+
return 3;
1460+
else if (cdclk > 480000)
1461+
return 2;
1462+
else if (cdclk > 312000)
1463+
return 1;
1464+
else
1465+
return 0;
1466+
}
1467+
14561468
static void icl_readout_refclk(struct drm_i915_private *dev_priv,
14571469
struct intel_cdclk_config *cdclk_config)
14581470
{
@@ -3242,6 +3254,13 @@ static const struct intel_cdclk_funcs mtl_cdclk_funcs = {
32423254
.calc_voltage_level = tgl_calc_voltage_level,
32433255
};
32443256

3257+
static const struct intel_cdclk_funcs rplu_cdclk_funcs = {
3258+
.get_cdclk = bxt_get_cdclk,
3259+
.set_cdclk = bxt_set_cdclk,
3260+
.modeset_calc_cdclk = bxt_modeset_calc_cdclk,
3261+
.calc_voltage_level = rplu_calc_voltage_level,
3262+
};
3263+
32453264
static const struct intel_cdclk_funcs tgl_cdclk_funcs = {
32463265
.get_cdclk = bxt_get_cdclk,
32473266
.set_cdclk = bxt_set_cdclk,
@@ -3384,14 +3403,17 @@ void intel_init_cdclk_hooks(struct drm_i915_private *dev_priv)
33843403
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
33853404
dev_priv->display.cdclk.table = dg2_cdclk_table;
33863405
} else if (IS_ALDERLAKE_P(dev_priv)) {
3387-
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
33883406
/* Wa_22011320316:adl-p[a0] */
3389-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
3407+
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
33903408
dev_priv->display.cdclk.table = adlp_a_step_cdclk_table;
3391-
else if (IS_ADLP_RPLU(dev_priv))
3409+
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
3410+
} else if (IS_ADLP_RPLU(dev_priv)) {
33923411
dev_priv->display.cdclk.table = rplu_cdclk_table;
3393-
else
3412+
dev_priv->display.funcs.cdclk = &rplu_cdclk_funcs;
3413+
} else {
33943414
dev_priv->display.cdclk.table = adlp_cdclk_table;
3415+
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
3416+
}
33953417
} else if (IS_ROCKETLAKE(dev_priv)) {
33963418
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
33973419
dev_priv->display.cdclk.table = rkl_cdclk_table;

0 commit comments

Comments
 (0)