Skip to content

Commit cb77043

Browse files
committed
kconfig: qconf: remove unused argument from ConfigList::updateList()
This function allocates 'item' before using it, so the argument 'item' is always shadowed. Remove the meaningless argument. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 9264115 commit cb77043

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

scripts/kconfig/qconf.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -404,15 +404,15 @@ void ConfigList::updateSelection(void)
404404
emit menuSelected(menu);
405405
}
406406

407-
void ConfigList::updateList(ConfigItem* item)
407+
void ConfigList::updateList()
408408
{
409409
ConfigItem* last = 0;
410+
ConfigItem *item;
410411

411412
if (!rootEntry) {
412413
if (mode != listMode)
413414
goto update;
414415
QTreeWidgetItemIterator it(this);
415-
ConfigItem* item;
416416

417417
while (*it) {
418418
item = (ConfigItem*)(*it);
@@ -990,7 +990,7 @@ void ConfigView::updateList(ConfigItem* item)
990990
ConfigView* v;
991991

992992
for (v = viewList; v; v = v->nextView)
993-
v->list->updateList(item);
993+
v->list->updateList();
994994
}
995995

996996
void ConfigView::updateListAll(void)

scripts/kconfig/qconf.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class ConfigList : public QTreeWidget {
6969
public slots:
7070
void setRootMenu(struct menu *menu);
7171

72-
void updateList(ConfigItem *item);
72+
void updateList();
7373
void setValue(ConfigItem* item, tristate val);
7474
void changeValue(ConfigItem* item);
7575
void updateSelection(void);
@@ -85,7 +85,7 @@ public slots:
8585
void updateListAll(void)
8686
{
8787
updateAll = true;
88-
updateList(NULL);
88+
updateList();
8989
updateAll = false;
9090
}
9191
void addColumn(colIdx idx)

0 commit comments

Comments
 (0)