Skip to content

Commit cbf5009

Browse files
arndbJassi Brar
authored andcommitted
mailbox: qcom-cpucp: fix 64BIT dependency
This newly added driver fails compile testing on 32-bit architectures because it relies on 64-bit MMIO register access: drivers/mailbox/qcom-cpucp-mbox.c: In function 'qcom_cpucp_mbox_irq_fn': drivers/mailbox/qcom-cpucp-mbox.c:54:18: error: implicit declaration of function 'readq'; did you mean 'readb'? [-Wimplicit-function-declaration] 54 | status = readq(cpucp->rx_base + APSS_CPUCP_RX_MBOX_STAT); | ^~~~~ | readb drivers/mailbox/qcom-cpucp-mbox.c:65:17: error: implicit declaration of function 'writeq'; did you mean 'writeb'? [-Wimplicit-function-declaration] 65 | writeq(BIT(i), cpucp->rx_base + APSS_CPUCP_RX_MBOX_CLEAR); | ^~~~~~ | writeb Change the Kconfig dependency to disallow that configuration as well. Fixes: 0e2a9a0 ("mailbox: Add support for QTI CPUCP mailbox controller") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Jassi Brar <[email protected]>
1 parent 0e2a9a0 commit cbf5009

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mailbox/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ config SPRD_MBOX
278278

279279
config QCOM_CPUCP_MBOX
280280
tristate "Qualcomm Technologies, Inc. CPUCP mailbox driver"
281-
depends on ARCH_QCOM || (COMPILE_TEST && 64BIT)
281+
depends on (ARCH_QCOM || COMPILE_TEST) && 64BIT
282282
help
283283
Qualcomm Technologies, Inc. CPUSS Control Processor (CPUCP) mailbox
284284
controller driver enables communication between AP and CPUCP. Say

0 commit comments

Comments
 (0)