Skip to content

Commit cc0c986

Browse files
bhadanednyaneshwarRadhakrishna Sripada
authored andcommitted
drm/i915/adlp: s/ADLP/ALDERLAKE_P for display and graphics step
Driver refers to the platform Alderlake P as ADLP in places and ALDERLAKE_P in some. Making the consistent change to avoid confusion of the right naming convention for the platform. v2: - Unrolled wrapper IS_ADLP_GRAPHICS_STEP and Replace - Added IS_ALDERLAKE_P() && IS_GRAPHICS_STEP() (Jani/Tvrtko). v3: - Removed unused macros of display steps. Cc: Tvrtko Ursulin <[email protected]> Cc: Jani Nikula <[email protected]> Cc: Anusha Srivatsa <[email protected]> Signed-off-by: Dnyaneshwar Bhadane <[email protected]> Acked-by: Jani Nikula <[email protected]> Signed-off-by: Radhakrishna Sripada <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 48077b0 commit cc0c986

File tree

5 files changed

+8
-15
lines changed

5 files changed

+8
-15
lines changed

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3567,7 +3567,7 @@ void intel_init_cdclk_hooks(struct drm_i915_private *dev_priv)
35673567
dev_priv->display.cdclk.table = dg2_cdclk_table;
35683568
} else if (IS_ALDERLAKE_P(dev_priv)) {
35693569
/* Wa_22011320316:adl-p[a0] */
3570-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
3570+
if (IS_ALDERLAKE_P(dev_priv) && IS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
35713571
dev_priv->display.cdclk.table = adlp_a_step_cdclk_table;
35723572
dev_priv->display.funcs.cdclk = &tgl_cdclk_funcs;
35733573
} else if (IS_ADLP_RPLU(dev_priv)) {

drivers/gpu/drm/i915/display/intel_dpll_mgr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3785,7 +3785,7 @@ static void adlp_cmtg_clock_gating_wa(struct drm_i915_private *i915, struct inte
37853785
{
37863786
u32 val;
37873787

3788-
if (!IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0) ||
3788+
if (!(IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0, STEP_B0)) ||
37893789
pll->info->id != DPLL_ID_ICL_DPLL0)
37903790
return;
37913791
/*

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ static void hsw_activate_psr2(struct intel_dp *intel_dp)
748748
}
749749

750750
/* Wa_22012278275:adl-p */
751-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_E0)) {
751+
if (IS_ALDERLAKE_P(dev_priv) && IS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_E0)) {
752752
static const u8 map[] = {
753753
2, /* 5 lines */
754754
1, /* 6 lines */
@@ -918,7 +918,7 @@ tgl_dc3co_exitline_compute_config(struct intel_dp *intel_dp,
918918
return;
919919

920920
/* Wa_16011303918:adl-p */
921-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
921+
if (IS_ALDERLAKE_P(dev_priv) && IS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
922922
return;
923923

924924
/*
@@ -1086,7 +1086,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
10861086
return false;
10871087
}
10881088

1089-
if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
1089+
if (IS_ALDERLAKE_P(dev_priv) && IS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
10901090
drm_dbg_kms(&dev_priv->drm, "PSR2 not completely functional in this stepping\n");
10911091
return false;
10921092
}
@@ -1144,7 +1144,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
11441144

11451145
/* Wa_16011303918:adl-p */
11461146
if (crtc_state->vrr.enable &&
1147-
IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
1147+
IS_ALDERLAKE_P(dev_priv) && IS_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
11481148
drm_dbg_kms(&dev_priv->drm,
11491149
"PSR2 not enabled, not compatible with HW stepping + VRR\n");
11501150
return false;

drivers/gpu/drm/i915/display/skl_universal_plane.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2174,7 +2174,7 @@ static bool skl_plane_has_rc_ccs(struct drm_i915_private *i915,
21742174
return false;
21752175

21762176
/* Wa_22011186057 */
2177-
if (IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
2177+
if (IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
21782178
return false;
21792179

21802180
if (DISPLAY_VER(i915) >= 11)
@@ -2200,7 +2200,7 @@ static bool gen12_plane_has_mc_ccs(struct drm_i915_private *i915,
22002200
return false;
22012201

22022202
/* Wa_22011186057 */
2203-
if (IS_ADLP_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
2203+
if (IS_ALDERLAKE_P(i915) && IS_DISPLAY_STEP(i915, STEP_A0, STEP_B0))
22042204
return false;
22052205

22062206
/* Wa_14013215631 */

drivers/gpu/drm/i915/i915_drv.h

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -661,13 +661,6 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
661661
(IS_ALDERLAKE_S(__i915) && \
662662
IS_GRAPHICS_STEP(__i915, since, until))
663663

664-
#define IS_ADLP_DISPLAY_STEP(__i915, since, until) \
665-
(IS_ALDERLAKE_P(__i915) && \
666-
IS_DISPLAY_STEP(__i915, since, until))
667-
668-
#define IS_ADLP_GRAPHICS_STEP(__i915, since, until) \
669-
(IS_ALDERLAKE_P(__i915) && \
670-
IS_GRAPHICS_STEP(__i915, since, until))
671664

672665
#define IS_XEHPSDV_GRAPHICS_STEP(__i915, since, until) \
673666
(IS_XEHPSDV(__i915) && IS_GRAPHICS_STEP(__i915, since, until))

0 commit comments

Comments
 (0)