Skip to content

Commit cca14de

Browse files
committed
OPP: Remove doc style comments for internal routines
These were previously exposed outside of the OPP core and needed doc style commenting. They aren't public now and don't need the same. This fixes warnings generated for builds with `W=1`: core.c:2105: warning: Function parameter or member 'opp_table' not described in '_opp_set_supported_hw' core.c:2105: warning: Excess function parameter 'dev' description in '_opp_set_supported_hw' core.c:2148: warning: Function parameter or member 'opp_table' not described in '_opp_set_prop_name' core.c:2148: warning: Excess function parameter 'dev' description in '_opp_set_prop_name' core.c:2189: warning: Function parameter or member 'opp_table' not described in '_opp_set_regulators' core.c:2189: warning: Excess function parameter 'count' description in '_opp_set_regulators' core.c:2293: warning: Function parameter or member 'opp_table' not described in '_opp_set_clknames' core.c:2293: warning: Function parameter or member 'config_clks' not described in '_opp_set_clknames' core.c:2391: warning: Function parameter or member 'opp_table' not described in '_opp_set_config_regulators_helper' core.c:2455: warning: Function parameter or member 'opp_table' not described in '_opp_attach_genpd' core.c:2682: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config' core.c:2682: warning: Excess function parameter 'opp_table' description in 'dev_pm_opp_clear_config' Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Signed-off-by: Viresh Kumar <[email protected]>
1 parent a0242c8 commit cca14de

File tree

1 file changed

+7
-72
lines changed

1 file changed

+7
-72
lines changed

drivers/opp/core.c

Lines changed: 7 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -2124,12 +2124,7 @@ int _opp_add_v1(struct opp_table *opp_table, struct device *dev,
21242124
return ret;
21252125
}
21262126

2127-
/**
2128-
* _opp_set_supported_hw() - Set supported platforms
2129-
* @dev: Device for which supported-hw has to be set.
2130-
* @versions: Array of hierarchy of versions to match.
2131-
* @count: Number of elements in the array.
2132-
*
2127+
/*
21332128
* This is required only for the V2 bindings, and it enables a platform to
21342129
* specify the hierarchy of versions it supports. OPP layer will then enable
21352130
* OPPs, which are available for those versions, based on its 'opp-supported-hw'
@@ -2152,14 +2147,6 @@ static int _opp_set_supported_hw(struct opp_table *opp_table,
21522147
return 0;
21532148
}
21542149

2155-
/**
2156-
* _opp_put_supported_hw() - Releases resources blocked for supported hw
2157-
* @opp_table: OPP table returned by _opp_set_supported_hw().
2158-
*
2159-
* This is required only for the V2 bindings, and is called for a matching
2160-
* _opp_set_supported_hw(). Until this is called, the opp_table structure
2161-
* will not be freed.
2162-
*/
21632150
static void _opp_put_supported_hw(struct opp_table *opp_table)
21642151
{
21652152
if (opp_table->supported_hw) {
@@ -2169,11 +2156,7 @@ static void _opp_put_supported_hw(struct opp_table *opp_table)
21692156
}
21702157
}
21712158

2172-
/**
2173-
* _opp_set_prop_name() - Set prop-extn name
2174-
* @dev: Device for which the prop-name has to be set.
2175-
* @name: name to postfix to properties.
2176-
*
2159+
/*
21772160
* This is required only for the V2 bindings, and it enables a platform to
21782161
* specify the extn to be used for certain property names. The properties to
21792162
* which the extension will apply are opp-microvolt and opp-microamp. OPP core
@@ -2191,14 +2174,6 @@ static int _opp_set_prop_name(struct opp_table *opp_table, const char *name)
21912174
return 0;
21922175
}
21932176

2194-
/**
2195-
* _opp_put_prop_name() - Releases resources blocked for prop-name
2196-
* @opp_table: OPP table returned by _opp_set_prop_name().
2197-
*
2198-
* This is required only for the V2 bindings, and is called for a matching
2199-
* _opp_set_prop_name(). Until this is called, the opp_table structure
2200-
* will not be freed.
2201-
*/
22022177
static void _opp_put_prop_name(struct opp_table *opp_table)
22032178
{
22042179
if (opp_table->prop_name) {
@@ -2207,12 +2182,7 @@ static void _opp_put_prop_name(struct opp_table *opp_table)
22072182
}
22082183
}
22092184

2210-
/**
2211-
* _opp_set_regulators() - Set regulator names for the device
2212-
* @dev: Device for which regulator name is being set.
2213-
* @names: Array of pointers to the names of the regulator.
2214-
* @count: Number of regulators.
2215-
*
2185+
/*
22162186
* In order to support OPP switching, OPP layer needs to know the name of the
22172187
* device's regulators, as the core would be required to switch voltages as
22182188
* well.
@@ -2274,10 +2244,6 @@ static int _opp_set_regulators(struct opp_table *opp_table, struct device *dev,
22742244
return ret;
22752245
}
22762246

2277-
/**
2278-
* _opp_put_regulators() - Releases resources blocked for regulator
2279-
* @opp_table: OPP table returned from _opp_set_regulators().
2280-
*/
22812247
static void _opp_put_regulators(struct opp_table *opp_table)
22822248
{
22832249
int i;
@@ -2309,11 +2275,7 @@ static void _put_clks(struct opp_table *opp_table, int count)
23092275
opp_table->clks = NULL;
23102276
}
23112277

2312-
/**
2313-
* _opp_set_clknames() - Set clk names for the device
2314-
* @dev: Device for which clk names is being set.
2315-
* @names: Clk names.
2316-
*
2278+
/*
23172279
* In order to support OPP switching, OPP layer needs to get pointers to the
23182280
* clocks for the device. Simple cases work fine without using this routine
23192281
* (i.e. by passing connection-id as NULL), but for a device with multiple
@@ -2397,10 +2359,6 @@ static int _opp_set_clknames(struct opp_table *opp_table, struct device *dev,
23972359
return ret;
23982360
}
23992361

2400-
/**
2401-
* _opp_put_clknames() - Releases resources blocked for clks.
2402-
* @opp_table: OPP table returned from _opp_set_clknames().
2403-
*/
24042362
static void _opp_put_clknames(struct opp_table *opp_table)
24052363
{
24062364
if (!opp_table->clks)
@@ -2412,11 +2370,7 @@ static void _opp_put_clknames(struct opp_table *opp_table)
24122370
_put_clks(opp_table, opp_table->clk_count);
24132371
}
24142372

2415-
/**
2416-
* _opp_set_config_regulators_helper() - Register custom set regulator helper.
2417-
* @dev: Device for which the helper is getting registered.
2418-
* @config_regulators: Custom set regulator helper.
2419-
*
2373+
/*
24202374
* This is useful to support platforms with multiple regulators per device.
24212375
*
24222376
* This must be called before any OPPs are initialized for the device.
@@ -2431,13 +2385,6 @@ static int _opp_set_config_regulators_helper(struct opp_table *opp_table,
24312385
return 0;
24322386
}
24332387

2434-
/**
2435-
* _opp_put_config_regulators_helper() - Releases resources blocked for
2436-
* config_regulators helper.
2437-
* @opp_table: OPP table returned from _opp_set_config_regulators_helper().
2438-
*
2439-
* Release resources blocked for platform specific config_regulators helper.
2440-
*/
24412388
static void _opp_put_config_regulators_helper(struct opp_table *opp_table)
24422389
{
24432390
if (opp_table->config_regulators)
@@ -2463,12 +2410,7 @@ static void _detach_genpd(struct opp_table *opp_table)
24632410
opp_table->genpd_virt_devs = NULL;
24642411
}
24652412

2466-
/**
2467-
* _opp_attach_genpd - Attach genpd(s) for the device and save virtual device pointer
2468-
* @dev: Consumer device for which the genpd is getting attached.
2469-
* @names: Null terminated array of pointers containing names of genpd to attach.
2470-
* @virt_devs: Pointer to return the array of virtual devices.
2471-
*
2413+
/*
24722414
* Multiple generic power domains for a device are supported with the help of
24732415
* virtual genpd devices, which are created for each consumer device - genpd
24742416
* pair. These are the device structures which are attached to the power domain
@@ -2544,13 +2486,6 @@ static int _opp_attach_genpd(struct opp_table *opp_table, struct device *dev,
25442486

25452487
}
25462488

2547-
/**
2548-
* _opp_detach_genpd() - Detach genpd(s) from the device.
2549-
* @opp_table: OPP table returned by _opp_attach_genpd().
2550-
*
2551-
* This detaches the genpd(s), resets the virtual device pointers, and puts the
2552-
* OPP table.
2553-
*/
25542489
static void _opp_detach_genpd(struct opp_table *opp_table)
25552490
{
25562491
/*
@@ -2702,7 +2637,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_set_config);
27022637

27032638
/**
27042639
* dev_pm_opp_clear_config() - Releases resources blocked for OPP configuration.
2705-
* @opp_table: OPP table returned from dev_pm_opp_set_config().
2640+
* @token: The token returned by dev_pm_opp_set_config() previously.
27062641
*
27072642
* This allows all device OPP configurations to be cleared at once. This must be
27082643
* called once for each call made to dev_pm_opp_set_config(), in order to free

0 commit comments

Comments
 (0)