Skip to content

Commit ccf8f7d

Browse files
Tom Rixkuba-moo
authored andcommitted
xen-netback: remove unused variables pending_idx and index
building with gcc and W=1 reports drivers/net/xen-netback/netback.c:886:21: error: variable ‘pending_idx’ set but not used [-Werror=unused-but-set-variable] 886 | u16 pending_idx; | ^~~~~~~~~~~ pending_idx is not used so remove it. Since index was only used to set pending_idx, remove index as well. Signed-off-by: Tom Rix <[email protected]> Reviewed-by: Juergen Gross <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 4db692d commit ccf8f7d

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

drivers/net/xen-netback/netback.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -883,11 +883,9 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
883883
struct xen_netif_tx_request txfrags[XEN_NETBK_LEGACY_SLOTS_MAX];
884884
struct xen_netif_extra_info extras[XEN_NETIF_EXTRA_TYPE_MAX-1];
885885
unsigned int extra_count;
886-
u16 pending_idx;
887886
RING_IDX idx;
888887
int work_to_do;
889888
unsigned int data_len;
890-
pending_ring_idx_t index;
891889

892890
if (queue->tx.sring->req_prod - queue->tx.req_cons >
893891
XEN_NETIF_TX_RING_SIZE) {
@@ -983,9 +981,6 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
983981
break;
984982
}
985983

986-
index = pending_index(queue->pending_cons);
987-
pending_idx = queue->pending_ring[index];
988-
989984
if (ret >= XEN_NETBK_LEGACY_SLOTS_MAX - 1 && data_len < txreq.size)
990985
data_len = txreq.size;
991986

0 commit comments

Comments
 (0)