Skip to content

Commit ccfe1fe

Browse files
qiangzh3paulmckrcu
authored andcommitted
rcu: Remove redundant call to rcu_boost_kthread_setaffinity()
The rcu_boost_kthread_setaffinity() function is invoked at rcutree_online_cpu() and rcutree_offline_cpu() time, early in the online timeline and late in the offline timeline, respectively. It is also invoked from rcutree_dead_cpu(), however, in the absence of userspace manipulations (for which userspace must take responsibility), this call is redundant with that from rcutree_offline_cpu(). This redundancy can be demonstrated by printing out the relevant cpumasks This commit therefore removes the call to rcu_boost_kthread_setaffinity() from rcutree_dead_cpu(). Signed-off-by: Zqiang <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]> Reviewed-by: Frederic Weisbecker <[email protected]>
1 parent 92987fe commit ccfe1fe

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

kernel/rcu/tree.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4076,15 +4076,10 @@ static void rcu_cleanup_dead_rnp(struct rcu_node *rnp_leaf)
40764076
*/
40774077
int rcutree_dead_cpu(unsigned int cpu)
40784078
{
4079-
struct rcu_data *rdp = per_cpu_ptr(&rcu_data, cpu);
4080-
struct rcu_node *rnp = rdp->mynode; /* Outgoing CPU's rdp & rnp. */
4081-
40824079
if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
40834080
return 0;
40844081

40854082
WRITE_ONCE(rcu_state.n_online_cpus, rcu_state.n_online_cpus - 1);
4086-
/* Adjust any no-longer-needed kthreads. */
4087-
rcu_boost_kthread_setaffinity(rnp, -1);
40884083
// Stop-machine done, so allow nohz_full to disable tick.
40894084
tick_dep_clear(TICK_DEP_BIT_RCU);
40904085
return 0;

0 commit comments

Comments
 (0)