Skip to content

Commit cd70237

Browse files
committed
firewire: ohci: deprecate debug parameter
Many tracepoints events have been added to 6.10 and 6.11 kernels. They are available as an alternative of debug parameter in firewire-ohci module. The logging messages enabled by the parameter require some cumbersomes in a point of maintenance; e.g. the code to decode transaction frame. This commit adds deprecation text to conduct users to them.. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent e2c87f4 commit cd70237

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

drivers/firewire/ohci.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ MODULE_PARM_DESC(quirks, "Chip quirks (default = 0"
396396

397397
static int param_debug;
398398
module_param_named(debug, param_debug, int, 0644);
399-
MODULE_PARM_DESC(debug, "Verbose logging (default = 0"
399+
MODULE_PARM_DESC(debug, "Verbose logging, deprecated in v6.11 kernel or later. (default = 0"
400400
", AT/AR events = " __stringify(OHCI_PARAM_DEBUG_AT_AR)
401401
", self-IDs = " __stringify(OHCI_PARAM_DEBUG_SELFIDS)
402402
", IRQs = " __stringify(OHCI_PARAM_DEBUG_IRQS)
@@ -2197,6 +2197,11 @@ static irqreturn_t irq_handler(int irq, void *data)
21972197
if (!event || !~event)
21982198
return IRQ_NONE;
21992199

2200+
if (unlikely(param_debug > 0)) {
2201+
dev_notice_ratelimited(ohci->card.device,
2202+
"The debug parameter is superceded by tracepoints events, and deprecated.");
2203+
}
2204+
22002205
/*
22012206
* busReset and postedWriteErr events must not be cleared yet
22022207
* (OHCI 1.1 clauses 7.2.3.2 and 13.2.8.1)

0 commit comments

Comments
 (0)