Skip to content

Commit cd8abf7

Browse files
Lucas Tanuretiwai
authored andcommitted
ALSA: hda: cs35l41: Add missing default cases
Add switch default cases at gpio pins configs Signed-off-by: Lucas Tanure <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent 77dc3a6 commit cd8abf7

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

sound/pci/hda/cs35l41_hda.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,9 @@ static void cs35l41_hda_playback_hook(struct device *dev, int action)
161161
if (reg_seq->close)
162162
ret = regmap_multi_reg_write(reg, reg_seq->close, reg_seq->num_close);
163163
break;
164+
default:
165+
ret = -EINVAL;
166+
break;
164167
}
165168

166169
if (ret)
@@ -227,6 +230,8 @@ static int cs35l41_hda_apply_properties(struct cs35l41_hda *cs35l41,
227230
internal_boost = true;
228231

229232
switch (hw_cfg->gpio1_func) {
233+
case CS35L41_NOT_USED:
234+
break;
230235
case CS35l41_VSPK_SWITCH:
231236
regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
232237
CS35L41_GPIO1_CTRL_MASK, 1 << CS35L41_GPIO1_CTRL_SHIFT);
@@ -235,13 +240,21 @@ static int cs35l41_hda_apply_properties(struct cs35l41_hda *cs35l41,
235240
regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
236241
CS35L41_GPIO1_CTRL_MASK, 2 << CS35L41_GPIO1_CTRL_SHIFT);
237242
break;
243+
default:
244+
dev_err(cs35l41->dev, "Invalid function %d for GPIO1\n", hw_cfg->gpio1_func);
245+
return -EINVAL;
238246
}
239247

240248
switch (hw_cfg->gpio2_func) {
249+
case CS35L41_NOT_USED:
250+
break;
241251
case CS35L41_INTERRUPT:
242252
regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
243253
CS35L41_GPIO2_CTRL_MASK, 2 << CS35L41_GPIO2_CTRL_SHIFT);
244254
break;
255+
default:
256+
dev_err(cs35l41->dev, "Invalid function %d for GPIO2\n", hw_cfg->gpio2_func);
257+
return -EINVAL;
245258
}
246259

247260
if (internal_boost) {

0 commit comments

Comments
 (0)