Skip to content

Commit cdd9335

Browse files
Sebastian Andrzej Siewiorpetrpavlu
authored andcommitted
module: Use RCU in module_kallsyms_on_each_symbol().
module::kallsyms can be accessed under RCU assumption. Use rcu_dereference() to access module::kallsyms. Update callers. Signed-off-by: Sebastian Andrzej Siewior <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Petr Pavlu <[email protected]>
1 parent f27d8ed commit cdd9335

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

kernel/module/kallsyms.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -476,10 +476,8 @@ int module_kallsyms_on_each_symbol(const char *modname,
476476
if (modname && strcmp(modname, mod->name))
477477
continue;
478478

479-
/* Use rcu_dereference_sched() to remain compliant with the sparse tool */
480-
preempt_disable();
481-
kallsyms = rcu_dereference_sched(mod->kallsyms);
482-
preempt_enable();
479+
kallsyms = rcu_dereference_check(mod->kallsyms,
480+
lockdep_is_held(&module_mutex));
483481

484482
for (i = 0; i < kallsyms->num_symtab; i++) {
485483
const Elf_Sym *sym = &kallsyms->symtab[i];

0 commit comments

Comments
 (0)