Skip to content

Commit ce0d697

Browse files
mbrost05lucasdemarchi
authored andcommitted
drm/xe: Ensure all locks released in exec IOCTL
In couple of places the wrong error handling goto was used to release locks. Fix these to ensure all locks dropped on exec IOCTL errors. Cc: Francois Dugast <[email protected]> Fixes: d16ef1a ("drm/xe/exec: Switch hw engine group execution mode upon job submission") Signed-off-by: Matthew Brost <[email protected]> Reviewed-by: Francois Dugast <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 9e7aacd) Signed-off-by: Lucas De Marchi <[email protected]>
1 parent 2d5404c commit ce0d697

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/xe/xe_exec.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,14 +203,14 @@ int xe_exec_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
203203
write_locked = false;
204204
}
205205
if (err)
206-
goto err_syncs;
206+
goto err_hw_exec_mode;
207207

208208
if (write_locked) {
209209
err = xe_vm_userptr_pin(vm);
210210
downgrade_write(&vm->lock);
211211
write_locked = false;
212212
if (err)
213-
goto err_hw_exec_mode;
213+
goto err_unlock_list;
214214
}
215215

216216
if (!args->num_batch_buffer) {

0 commit comments

Comments
 (0)