Skip to content

Commit ce41896

Browse files
Frederic Weisbeckerpaulmckrcu
authored andcommitted
rcu/nocb: Fix segcblist state machine comments about bypass
The parts explaining the bypass lifecycle in (de-)offloading are out of date and/or wrong. Bypass is simply enabled whenever SEGCBLIST_RCU_CORE flag is off. Fix the comments accordingly. Signed-off-by: Frederic Weisbecker <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 1613e60 commit ce41896

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

include/linux/rcu_segcblist.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ struct rcu_cblist {
141141
* | SEGCBLIST_KTHREAD_GP |
142142
* | |
143143
* | CB/GP kthreads handle callbacks holding nocb_lock, local rcu_core() |
144-
* | handles callbacks concurrently. Bypass enqueue is enabled. |
144+
* | handles callbacks concurrently. Bypass enqueue is disabled. |
145145
* | Invoke RCU core so we make sure not to preempt it in the middle with |
146146
* | leaving some urgent work unattended within a jiffy. |
147147
* ----------------------------------------------------------------------------
@@ -154,8 +154,7 @@ struct rcu_cblist {
154154
* | SEGCBLIST_KTHREAD_GP |
155155
* | |
156156
* | CB/GP kthreads and local rcu_core() handle callbacks concurrently |
157-
* | holding nocb_lock. Wake up CB and GP kthreads if necessary. Disable |
158-
* | bypass enqueue. |
157+
* | holding nocb_lock. Wake up CB and GP kthreads if necessary. |
159158
* ----------------------------------------------------------------------------
160159
* |
161160
* v
@@ -185,7 +184,7 @@ struct rcu_cblist {
185184
* | |
186185
* | Callbacks processed by rcu_core() from softirqs or local |
187186
* | rcuc kthread, while holding nocb_lock. Forbid nocb_timer to be armed. |
188-
* | Flush pending nocb_timer. Flush nocb bypass callbacks. |
187+
* | Flush pending nocb_timer. |
189188
* ----------------------------------------------------------------------------
190189
* |
191190
* v

0 commit comments

Comments
 (0)