Skip to content

Commit ceb7560

Browse files
Aurabindo Pillaialexdeucher
authored andcommitted
drm/amd/display: add workaround for subvp cursor corruption for DCN32/321
[Why&How] Kernel does not have a means to tell the userspace to use software cursor. Due to lack of this functionality, reducing the max cursor size is the only way to ensure that power savings of Subview port feature is utilized for asics that support it. The workaround could be removed after cursor caching is fixed while a subviewport config is active. Tested-by: Daniel Wheeler <[email protected]> Reviewed-by: Alvin Lee <[email protected]> Acked-by: Pavle Kotarac <[email protected]> Signed-off-by: Aurabindo Pillai <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 1bb8df6 commit ceb7560

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

drivers/gpu/drm/amd/display/dc/dcn32/dcn32_resource.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2040,7 +2040,8 @@ static bool dcn32_resource_construct(
20402040
dc->caps.max_downscale_ratio = 600;
20412041
dc->caps.i2c_speed_in_khz = 100;
20422042
dc->caps.i2c_speed_in_khz_hdcp = 100; /*1.4 w/a applied by default*/
2043-
dc->caps.max_cursor_size = 256;
2043+
/* TODO: Bring max_cursor_size back to 256 after subvp cursor corruption is fixed*/
2044+
dc->caps.max_cursor_size = 64;
20442045
dc->caps.min_horizontal_blanking_period = 80;
20452046
dc->caps.dmdata_alloc_size = 2048;
20462047
dc->caps.mall_size_per_mem_channel = 0;

drivers/gpu/drm/amd/display/dc/dcn321/dcn321_resource.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1652,7 +1652,8 @@ static bool dcn321_resource_construct(
16521652
dc->caps.max_downscale_ratio = 600;
16531653
dc->caps.i2c_speed_in_khz = 100;
16541654
dc->caps.i2c_speed_in_khz_hdcp = 100; /*1.4 w/a applied by default*/
1655-
dc->caps.max_cursor_size = 256;
1655+
/* TODO: Bring max cursor size back to 256 after subvp cursor corruption is fixed*/
1656+
dc->caps.max_cursor_size = 64;
16561657
dc->caps.min_horizontal_blanking_period = 80;
16571658
dc->caps.dmdata_alloc_size = 2048;
16581659
dc->caps.mall_size_per_mem_channel = 0;

0 commit comments

Comments
 (0)