Skip to content

Commit ced6332

Browse files
Oliver Bartarodrigovivi
authored andcommitted
drm/i915: HDCP: fix Ri prime check done during link check
The check was always succeeding even in case of a mismatch due to the HDCP_STATUS_ENC bit being set. Make sure both bits are actually set. Signed-off-by: Oliver Barta <[email protected]> Fixes: 2320175 ("drm/i915: Implement HDCP for HDMI") Reviewed-by: Ramalingam C <[email protected]> Signed-off-by: Jani Nikula <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] (cherry picked from commit 3ffaf56) Signed-off-by: Rodrigo Vivi <[email protected]>
1 parent e1eb075 commit ced6332

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/gpu/drm/i915/display/intel_hdmi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1536,7 +1536,8 @@ bool intel_hdmi_hdcp_check_link(struct intel_digital_port *intel_dig_port)
15361536
intel_de_write(i915, HDCP_RPRIME(i915, cpu_transcoder, port), ri.reg);
15371537

15381538
/* Wait for Ri prime match */
1539-
if (wait_for(intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) &
1539+
if (wait_for((intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)) &
1540+
(HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC)) ==
15401541
(HDCP_STATUS_RI_MATCH | HDCP_STATUS_ENC), 1)) {
15411542
DRM_ERROR("Ri' mismatch detected, link check failed (%x)\n",
15421543
intel_de_read(i915, HDCP_STATUS(i915, cpu_transcoder, port)));

0 commit comments

Comments
 (0)