Skip to content

Commit cf2b012

Browse files
adimikegroeck
authored andcommitted
hwmon: (pmbus/ltc2978) Fix PMBus polling of MFR_COMMON definitions.
Change 21537dc driver PMBus polling of MFR_COMMON from bits 5/4 to bits 6/5. This fixs a LTC297X family bug where polling always returns not busy even when the part is busy. This fixes a LTC388X and LTM467X bug where polling used PEND and NOT_IN_TRANS, and BUSY was not polled, which can lead to NACKing of commands. LTC388X and LTM467X modules now poll BUSY and PEND, increasing reliability by eliminating NACKing of commands. Signed-off-by: Mike Jones <[email protected]> Link: https://lore.kernel.org/r/[email protected] Fixes: e04d1ce ("hwmon: (ltc2978) Add polling for chips requiring it") Signed-off-by: Guenter Roeck <[email protected]>
1 parent bb6d3fb commit cf2b012

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/hwmon/pmbus/ltc2978.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ enum chips { ltc2974, ltc2975, ltc2977, ltc2978, ltc2980, ltc3880, ltc3882,
8282

8383
#define LTC_POLL_TIMEOUT 100 /* in milli-seconds */
8484

85-
#define LTC_NOT_BUSY BIT(5)
86-
#define LTC_NOT_PENDING BIT(4)
85+
#define LTC_NOT_BUSY BIT(6)
86+
#define LTC_NOT_PENDING BIT(5)
8787

8888
/*
8989
* LTC2978 clears peak data whenever the CLEAR_FAULTS command is executed, which

0 commit comments

Comments
 (0)