Skip to content

Commit cf738cc

Browse files
Hans Verkuilmchehab
authored andcommitted
media: atomisp: add missing wait_prepare/finish ops
Without these ops the v4l2-compliance blocking wait test will fail. These ops are required to ensure that when VIDIOC_DQBUF has to wait for buffers to arrive, the queue lock is correctly released and retaken. Otherwise the wait for a buffer would block all other queue ioctls. Signed-off-by: Hans Verkuil <[email protected]> Link: https://lore.kernel.org/r/9f401f3732dd728e3d2ca508002c97b80a2eae30.1725265884.git.hverkuil-cisco@xs4all.nl Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent d579ef0 commit cf738cc

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/staging/media/atomisp/pci/atomisp_fops.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -441,6 +441,8 @@ const struct vb2_ops atomisp_vb2_ops = {
441441
.buf_queue = atomisp_buf_queue,
442442
.start_streaming = atomisp_start_streaming,
443443
.stop_streaming = atomisp_stop_streaming,
444+
.wait_prepare = vb2_ops_wait_prepare,
445+
.wait_finish = vb2_ops_wait_finish,
444446
};
445447

446448
static void atomisp_dev_init_struct(struct atomisp_device *isp)

0 commit comments

Comments
 (0)