Skip to content

Commit cf7ab00

Browse files
amschuma-ntapTrond Myklebust
authored andcommitted
NFS: Remove the nfs4_label argument from nfs_fhget()
Signed-off-by: Anna Schumaker <[email protected]> Signed-off-by: Trond Myklebust <[email protected]>
1 parent cc6f329 commit cf7ab00

File tree

7 files changed

+11
-12
lines changed

7 files changed

+11
-12
lines changed

fs/nfs/dir.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -697,7 +697,7 @@ void nfs_prime_dcache(struct dentry *parent, struct nfs_entry *entry,
697697
goto out;
698698
}
699699

700-
inode = nfs_fhget(dentry->d_sb, entry->fh, entry->fattr, entry->fattr->label);
700+
inode = nfs_fhget(dentry->d_sb, entry->fh, entry->fattr);
701701
alias = d_splice_alias(inode, dentry);
702702
d_lookup_done(dentry);
703703
if (alias) {
@@ -1782,7 +1782,7 @@ struct dentry *nfs_lookup(struct inode *dir, struct dentry * dentry, unsigned in
17821782
res = ERR_PTR(error);
17831783
goto out;
17841784
}
1785-
inode = nfs_fhget(dentry->d_sb, fhandle, fattr, fattr->label);
1785+
inode = nfs_fhget(dentry->d_sb, fhandle, fattr);
17861786
res = ERR_CAST(inode);
17871787
if (IS_ERR(res))
17881788
goto out;
@@ -2059,7 +2059,7 @@ nfs_add_or_obtain(struct dentry *dentry, struct nfs_fh *fhandle,
20592059
if (error < 0)
20602060
goto out_error;
20612061
}
2062-
inode = nfs_fhget(dentry->d_sb, fhandle, fattr, fattr->label);
2062+
inode = nfs_fhget(dentry->d_sb, fhandle, fattr);
20632063
d = d_splice_alias(inode, dentry);
20642064
out:
20652065
dput(parent);

fs/nfs/export.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ nfs_fh_to_dentry(struct super_block *sb, struct fid *fid,
103103
goto out_free_fattr;
104104
}
105105

106-
inode = nfs_fhget(sb, server_fh, fattr, fattr->label);
106+
inode = nfs_fhget(sb, server_fh, fattr);
107107

108108
out_found:
109109
dentry = d_obtain_alias(inode);
@@ -138,7 +138,7 @@ nfs_get_parent(struct dentry *dentry)
138138
goto out;
139139
}
140140

141-
pinode = nfs_fhget(sb, &fh, fattr, fattr->label);
141+
pinode = nfs_fhget(sb, &fh, fattr);
142142
parent = d_obtain_alias(pinode);
143143
out:
144144
nfs_free_fattr(fattr);

fs/nfs/getroot.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ int nfs_get_root(struct super_block *s, struct fs_context *fc)
9191
goto out_fattr;
9292
}
9393

94-
inode = nfs_fhget(s, ctx->mntfh, fsinfo.fattr, NULL);
94+
inode = nfs_fhget(s, ctx->mntfh, fsinfo.fattr);
9595
if (IS_ERR(inode)) {
9696
dprintk("nfs_get_root: get root inode failed\n");
9797
error = PTR_ERR(inode);

fs/nfs/inode.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,7 @@ static void nfs_inode_init_dir(struct nfs_inode *nfsi)
448448
* instead of inode number.
449449
*/
450450
struct inode *
451-
nfs_fhget(struct super_block *sb, struct nfs_fh *fh, struct nfs_fattr *fattr, struct nfs4_label *label)
451+
nfs_fhget(struct super_block *sb, struct nfs_fh *fh, struct nfs_fattr *fattr)
452452
{
453453
struct nfs_find_desc desc = {
454454
.fh = fh,
@@ -581,7 +581,7 @@ nfs_fhget(struct super_block *sb, struct nfs_fh *fh, struct nfs_fattr *fattr, st
581581
fattr->size != 0)
582582
nfs_set_cache_invalid(inode, NFS_INO_INVALID_BLOCKS);
583583

584-
nfs_setsecurity(inode, fattr, label);
584+
nfs_setsecurity(inode, fattr, fattr->label);
585585

586586
nfsi->attrtimeo = NFS_MINATTRTIMEO(inode);
587587
nfsi->attrtimeo_timestamp = now;

fs/nfs/nfs4file.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -344,8 +344,7 @@ static struct file *__nfs42_ssc_open(struct vfsmount *ss_mnt,
344344
goto out;
345345
snprintf(read_name, len, SSC_READ_NAME_BODY, read_name_gen++);
346346

347-
r_ino = nfs_fhget(ss_mnt->mnt_root->d_inode->i_sb, src_fh, fattr,
348-
NULL);
347+
r_ino = nfs_fhget(ss_mnt->mnt_root->d_inode->i_sb, src_fh, fattr);
349348
if (IS_ERR(r_ino)) {
350349
res = ERR_CAST(r_ino);
351350
goto out_free_name;

fs/nfs/nfs4proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2008,7 +2008,7 @@ nfs4_opendata_get_inode(struct nfs4_opendata *data)
20082008
if (!(data->f_attr.valid & NFS_ATTR_FATTR))
20092009
return ERR_PTR(-EAGAIN);
20102010
inode = nfs_fhget(data->dir->d_sb, &data->o_res.fh,
2011-
&data->f_attr, data->f_attr.label);
2011+
&data->f_attr);
20122012
break;
20132013
default:
20142014
inode = d_inode(data->dentry);

include/linux/nfs_fs.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ extern void nfs_zap_caches(struct inode *);
388388
extern void nfs_set_inode_stale(struct inode *inode);
389389
extern void nfs_invalidate_atime(struct inode *);
390390
extern struct inode *nfs_fhget(struct super_block *, struct nfs_fh *,
391-
struct nfs_fattr *, struct nfs4_label *);
391+
struct nfs_fattr *);
392392
struct inode *nfs_ilookup(struct super_block *sb, struct nfs_fattr *, struct nfs_fh *);
393393
extern int nfs_refresh_inode(struct inode *, struct nfs_fattr *);
394394
extern int nfs_post_op_update_inode(struct inode *inode, struct nfs_fattr *fattr);

0 commit comments

Comments
 (0)