Skip to content

Commit cfa5f33

Browse files
dhowellsbrauner
authored andcommitted
devpts: Fix type for uid and gid params
Fix devpts to parse uid and gid params using the correct type so that they get interpreted in the context of the user namespace. Fixes: cc0876f ("vfs: Convert devpts to use the new mount API") Reported-by: Debarshi Ray <[email protected]> Closes: containers/podman#25751 Signed-off-by: Giuseppe Scrivano <[email protected]> Signed-off-by: David Howells <[email protected]> Link: https://lore.kernel.org/r/[email protected] cc: Eric Sandeen <[email protected]> cc: [email protected] Signed-off-by: Christian Brauner <[email protected]>
1 parent 0af2f6b commit cfa5f33

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

fs/devpts/inode.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ enum {
8989
};
9090

9191
static const struct fs_parameter_spec devpts_param_specs[] = {
92-
fsparam_u32 ("gid", Opt_gid),
92+
fsparam_gid ("gid", Opt_gid),
9393
fsparam_s32 ("max", Opt_max),
9494
fsparam_u32oct ("mode", Opt_mode),
9595
fsparam_flag ("newinstance", Opt_newinstance),
9696
fsparam_u32oct ("ptmxmode", Opt_ptmxmode),
97-
fsparam_u32 ("uid", Opt_uid),
97+
fsparam_uid ("uid", Opt_uid),
9898
{}
9999
};
100100

0 commit comments

Comments
 (0)