Skip to content

Commit cfa842c

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_kbd_led_backlight: remove unneeded if-statement
Remove an unneeded if-statement. Also s/error/err/. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tzung-Bi Shih <[email protected]>
1 parent fc033cf commit cfa842c

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

drivers/platform/chrome/cros_kbd_led_backlight.c

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ static int keyboard_led_probe(struct platform_device *pdev)
229229
{
230230
const struct keyboard_led_drvdata *drvdata;
231231
struct keyboard_led *keyboard_led;
232-
int error;
232+
int err;
233233

234234
if (keyboard_led_is_mfd_device(pdev))
235235
drvdata = &keyboard_led_drvdata_ec_pwm_mfd;
@@ -244,9 +244,9 @@ static int keyboard_led_probe(struct platform_device *pdev)
244244
platform_set_drvdata(pdev, keyboard_led);
245245

246246
if (drvdata->init) {
247-
error = drvdata->init(pdev);
248-
if (error)
249-
return error;
247+
err = drvdata->init(pdev);
248+
if (err)
249+
return err;
250250
}
251251

252252
keyboard_led->cdev.name = "chromeos::kbd_backlight";
@@ -256,13 +256,10 @@ static int keyboard_led_probe(struct platform_device *pdev)
256256
keyboard_led->cdev.brightness_set_blocking = drvdata->brightness_set_blocking;
257257
keyboard_led->cdev.brightness_get = drvdata->brightness_get;
258258

259-
error = devm_led_classdev_register(&pdev->dev, &keyboard_led->cdev);
260-
if (error == -EEXIST) /* Already bound via other mechanism */
259+
err = devm_led_classdev_register(&pdev->dev, &keyboard_led->cdev);
260+
if (err == -EEXIST) /* Already bound via other mechanism */
261261
return -ENODEV;
262-
if (error)
263-
return error;
264-
265-
return 0;
262+
return err;
266263
}
267264

268265
#ifdef CONFIG_ACPI

0 commit comments

Comments
 (0)