Skip to content

Commit cfbbd48

Browse files
matttbekuba-moo
authored andcommitted
mptcp: no admin perm to list endpoints
During the switch to YNL, the command to list all endpoints has been accidentally restricted to users with admin permissions. It looks like there are no reasons to have this restriction which makes it harder for a user to quickly check if the endpoint list has been correctly populated by an automated tool. Best to go back to the previous behaviour then. mptcp_pm_gen.c has been modified using ynl-gen-c.py: $ ./tools/net/ynl/ynl-gen-c.py --mode kernel \ --spec Documentation/netlink/specs/mptcp_pm.yaml --source \ -o net/mptcp/mptcp_pm_gen.c The header file doesn't need to be regenerated. Fixes: 1d0507f ("net: mptcp: convert netlink from small_ops to ops") Cc: [email protected] Reviewed-by: Davide Caratti <[email protected]> Reviewed-by: Mat Martineau <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 256748d commit cfbbd48

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

Documentation/netlink/specs/mptcp_pm.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,6 @@ operations:
293293
doc: Get endpoint information
294294
attribute-set: attr
295295
dont-validate: [ strict ]
296-
flags: [ uns-admin-perm ]
297296
do: &get-addr-attrs
298297
request:
299298
attributes:

net/mptcp/mptcp_pm_gen.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,6 @@ const struct genl_ops mptcp_pm_nl_ops[11] = {
112112
.dumpit = mptcp_pm_nl_get_addr_dumpit,
113113
.policy = mptcp_pm_get_addr_nl_policy,
114114
.maxattr = MPTCP_PM_ATTR_TOKEN,
115-
.flags = GENL_UNS_ADMIN_PERM,
116115
},
117116
{
118117
.cmd = MPTCP_PM_CMD_FLUSH_ADDRS,

0 commit comments

Comments
 (0)