dm ioctl: a small code cleanup in list_version_get_info

Mikulas Patocka · Mike Snitzer · commit d043f9a1ca92 · 2022-12-01T11:43:41.000-05:00
No need to modify info-&gt;vers if we overwrite it immediately.

Signed-off-by: Mikulas Patocka &lt;mpatocka@redhat.com&gt;
Signed-off-by: Mike Snitzer &lt;snitzer@kernel.org&gt;
diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
@@ -681,7 +681,7 @@ static void list_version_get_info(struct target_type *tt, void *param)
     strcpy(info->vers->name, tt->name);
 
     info->old_vers = info->vers;
-    info->vers = align_ptr(((void *) ++info->vers) + strlen(tt->name) + 1);
+    info->vers = align_ptr((void *)(info->vers + 1) + strlen(tt->name) + 1);
 }
 
 static int __list_versions(struct dm_ioctl *param, size_t param_size, const char *name)

Original file line number	Diff line number	Diff line change
`@@ -681,7 +681,7 @@ static void list_version_get_info(struct target_type tt, void param)`
`681`	`681`	`strcpy(info->vers->name, tt->name);`
`682`	`682`
`683`	`683`	`info->old_vers = info->vers;`
`684`		`- info->vers = align_ptr(((void *) ++info->vers) + strlen(tt->name) + 1);`
	`684`	`+ info->vers = align_ptr((void *)(info->vers + 1) + strlen(tt->name) + 1);`
`685`	`685`	`}`
`686`	`686`
`687`	`687`	`static int __list_versions(struct dm_ioctl param, size_t param_size, const char name)`