Skip to content

Commit d0a0c91

Browse files
fabioestevamrobherring
authored andcommitted
dt-bindings: display: elgin,jg10309-01: Add own binding
Currently, the compatible 'elgin,jg10309-01' is documented inside trivial-devices.yaml, but it does not fit well there as it requires extra properties such as spi-max-frequency, spi-cpha, and spi-cpol. This causes the following dt-schema warnings: make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb -j12 DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb rv1108-elgin-r1.dtb:display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: ... Fix this problem by introducing a specific binding for the Elgin JG10309-01 SPI-controlled display. Signed-off-by: Fabio Estevam <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Rob Herring (Arm) <[email protected]>
1 parent 9852d85 commit d0a0c91

File tree

2 files changed

+54
-2
lines changed

2 files changed

+54
-2
lines changed
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
2+
%YAML 1.2
3+
---
4+
$id: http://devicetree.org/schemas/display/elgin,jg10309-01.yaml#
5+
$schema: http://devicetree.org/meta-schemas/core.yaml#
6+
7+
title: Elgin JG10309-01 SPI-controlled display
8+
9+
maintainers:
10+
- Fabio Estevam <[email protected]>
11+
12+
description: |
13+
The Elgin JG10309-01 SPI-controlled display is used on the RV1108-Elgin-r1
14+
board and is a custom display.
15+
16+
allOf:
17+
- $ref: /schemas/spi/spi-peripheral-props.yaml#
18+
19+
properties:
20+
compatible:
21+
const: elgin,jg10309-01
22+
23+
reg:
24+
maxItems: 1
25+
26+
spi-max-frequency:
27+
maximum: 24000000
28+
29+
spi-cpha: true
30+
31+
spi-cpol: true
32+
33+
required:
34+
- compatible
35+
- reg
36+
- spi-cpha
37+
- spi-cpol
38+
39+
additionalProperties: false
40+
41+
examples:
42+
- |
43+
spi {
44+
#address-cells = <1>;
45+
#size-cells = <0>;
46+
47+
display@0 {
48+
compatible = "elgin,jg10309-01";
49+
reg = <0>;
50+
spi-max-frequency = <24000000>;
51+
spi-cpha;
52+
spi-cpol;
53+
};
54+
};

Documentation/devicetree/bindings/trivial-devices.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,6 @@ properties:
101101
- domintech,dmard09
102102
# DMARD10: 3-axis Accelerometer
103103
- domintech,dmard10
104-
# Elgin SPI-controlled LCD
105-
- elgin,jg10309-01
106104
# MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
107105
- fsl,mma7660
108106
# MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer

0 commit comments

Comments
 (0)