Skip to content

Commit d0bac4e

Browse files
fltorobclark
authored andcommitted
drm/msm/a6xx: set ubwc config for A640 and A650
This is required for A640 and A650 to be able to share UBWC-compressed images with other HW such as display, which expect this configuration. Signed-off-by: Jonathan Marek <[email protected]> Reviewed-by: Jordan Crouse <[email protected]> Signed-off-by: Rob Clark <[email protected]>
1 parent b5e02e1 commit d0bac4e

File tree

1 file changed

+32
-6
lines changed

1 file changed

+32
-6
lines changed

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,37 @@ static void a6xx_set_hwcg(struct msm_gpu *gpu, bool state)
292292
gpu_write(gpu, REG_A6XX_RBBM_CLOCK_CNTL, state ? 0x8aa8aa02 : 0);
293293
}
294294

295+
static void a6xx_set_ubwc_config(struct msm_gpu *gpu)
296+
{
297+
struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
298+
u32 lower_bit = 2;
299+
u32 amsbc = 0;
300+
u32 rgb565_predicator = 0;
301+
u32 uavflagprd_inv = 0;
302+
303+
/* a618 is using the hw default values */
304+
if (adreno_is_a618(adreno_gpu))
305+
return;
306+
307+
if (adreno_is_a640(adreno_gpu))
308+
amsbc = 1;
309+
310+
if (adreno_is_a650(adreno_gpu)) {
311+
/* TODO: get ddr type from bootloader and use 2 for LPDDR4 */
312+
lower_bit = 3;
313+
amsbc = 1;
314+
rgb565_predicator = 1;
315+
uavflagprd_inv = 2;
316+
}
317+
318+
gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL,
319+
rgb565_predicator << 11 | amsbc << 4 | lower_bit << 1);
320+
gpu_write(gpu, REG_A6XX_TPL1_NC_MODE_CNTL, lower_bit << 1);
321+
gpu_write(gpu, REG_A6XX_SP_NC_MODE_CNTL,
322+
uavflagprd_inv >> 4 | lower_bit << 1);
323+
gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL, lower_bit << 21);
324+
}
325+
295326
static int a6xx_cp_init(struct msm_gpu *gpu)
296327
{
297328
struct msm_ringbuffer *ring = gpu->rb[0];
@@ -481,12 +512,7 @@ static int a6xx_hw_init(struct msm_gpu *gpu)
481512
/* Select CP0 to always count cycles */
482513
gpu_write(gpu, REG_A6XX_CP_PERFCTR_CP_SEL_0, PERF_CP_ALWAYS_COUNT);
483514

484-
if (adreno_is_a630(adreno_gpu)) {
485-
gpu_write(gpu, REG_A6XX_RB_NC_MODE_CNTL, 2 << 1);
486-
gpu_write(gpu, REG_A6XX_TPL1_NC_MODE_CNTL, 2 << 1);
487-
gpu_write(gpu, REG_A6XX_SP_NC_MODE_CNTL, 2 << 1);
488-
gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL, 2 << 21);
489-
}
515+
a6xx_set_ubwc_config(gpu);
490516

491517
/* Enable fault detection */
492518
gpu_write(gpu, REG_A6XX_RBBM_INTERFACE_HANG_INT_CNTL,

0 commit comments

Comments
 (0)