Skip to content

Commit d19ab1f

Browse files
arndbmiquelraynal
authored andcommitted
mtd: cfi: allow building spi-intel standalone
When MTD or MTD_CFI_GEOMETRY is disabled, the spi-intel driver fails to build, as it includes the shared CFI header: include/linux/mtd/cfi.h:62:2: error: #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. [-Werror=cpp] 62 | #warning No CONFIG_MTD_CFI_Ix selected. No NOR chip support can work. linux/mtd/spi-nor.h does not actually need to include cfi.h, so remove the inclusion here to fix the warning. This uncovers a missing #include in spi-nor/core.c so add that there to prevent a different build issue. Fixes: e23e5a0 ("mtd: spi-nor: intel-spi: Convert to SPI MEM") Signed-off-by: Arnd Bergmann <[email protected]> Reviewed-by: Mika Westerberg <[email protected]> Reviewed-by: Tokunori Ikegami <[email protected]> Acked-by: Pratyush Yadav <[email protected]> Reviewed-by: Tudor Ambarus <[email protected]> Signed-off-by: Miquel Raynal <[email protected]> Link: https://lore.kernel.org/linux-mtd/[email protected]
1 parent 105c14b commit d19ab1f

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

drivers/mtd/spi-nor/core.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <linux/err.h>
1111
#include <linux/errno.h>
1212
#include <linux/module.h>
13+
#include <linux/delay.h>
1314
#include <linux/device.h>
1415
#include <linux/mutex.h>
1516
#include <linux/math64.h>

include/linux/mtd/spi-nor.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#define __LINUX_MTD_SPI_NOR_H
88

99
#include <linux/bitops.h>
10-
#include <linux/mtd/cfi.h>
1110
#include <linux/mtd/mtd.h>
1211
#include <linux/spi/spi-mem.h>
1312

0 commit comments

Comments
 (0)