Skip to content

Commit d1c2088

Browse files
bijudasgeertu
authored andcommitted
clk: renesas: rzg2l: Fix CPG_SIPLL5_CLK1 register write
As per the RZ/G2L HW(Rev.1.30 May2023) manual, there are no "write enable" bits in the CPG_SIPLL5_CLK1 register. So fix the CPG_SIPLL5_CLK register write by removing the "write enable" bits. Fixes: 1561380 ("clk: renesas: rzg2l: Add FOUTPOSTDIV clk support") Signed-off-by: Biju Das <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Link: https://lore.kernel.org/r/[email protected] [geert: Remove CPG_SIPLL5_CLK1_*_WEN bit definitions] Signed-off-by: Geert Uytterhoeven <[email protected]>
1 parent 7f91fe3 commit d1c2088

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

drivers/clk/renesas/rzg2l-cpg.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -603,10 +603,8 @@ static int rzg2l_cpg_sipll5_set_rate(struct clk_hw *hw,
603603
}
604604

605605
/* Output clock setting 1 */
606-
writel(CPG_SIPLL5_CLK1_POSTDIV1_WEN | CPG_SIPLL5_CLK1_POSTDIV2_WEN |
607-
CPG_SIPLL5_CLK1_REFDIV_WEN | (params.pl5_postdiv1 << 0) |
608-
(params.pl5_postdiv2 << 4) | (params.pl5_refdiv << 8),
609-
priv->base + CPG_SIPLL5_CLK1);
606+
writel((params.pl5_postdiv1 << 0) | (params.pl5_postdiv2 << 4) |
607+
(params.pl5_refdiv << 8), priv->base + CPG_SIPLL5_CLK1);
610608

611609
/* Output clock setting, SSCG modulation value setting 3 */
612610
writel((params.pl5_fracin << 8), priv->base + CPG_SIPLL5_CLK3);

drivers/clk/renesas/rzg2l-cpg.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,6 @@
3232
#define CPG_SIPLL5_STBY_RESETB_WEN BIT(16)
3333
#define CPG_SIPLL5_STBY_SSCG_EN_WEN BIT(18)
3434
#define CPG_SIPLL5_STBY_DOWNSPREAD_WEN BIT(20)
35-
#define CPG_SIPLL5_CLK1_POSTDIV1_WEN BIT(16)
36-
#define CPG_SIPLL5_CLK1_POSTDIV2_WEN BIT(20)
37-
#define CPG_SIPLL5_CLK1_REFDIV_WEN BIT(24)
3835
#define CPG_SIPLL5_CLK4_RESV_LSB (0xFF)
3936
#define CPG_SIPLL5_MON_PLL5_LOCK BIT(4)
4037

0 commit comments

Comments
 (0)