Skip to content

Commit d1dd75d

Browse files
mcgrofbrauner
authored andcommitted
iomap: remove set_memor_ro() on zero page
Stephen reported a boot failure on ppc power8 system where set_memor_ro() on the new zero page failed [0]. Christophe Leroy further clarifies we can't use this on on linear memory on ppc, and so instead of special casing this just for PowerPC [2] remove the call as suggested by Darrick. [0] https://lore.kernel.org/all/[email protected]/T/#u [1] https://lore.kernel.org/all/[email protected]/ [2] https://lore.kernel.org/all/[email protected]/ Reported-by: Stephen Rothwell <[email protected]> Suggested-by: Darrick J. Wong <[email protected]> Signed-off-by: Luis Chamberlain <[email protected]> Link: https://lore.kernel.org/r/[email protected] Tested-by: Stephen Rothwell <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Reviewed-by: Darrick J. Wong <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent 7ccd606 commit d1dd75d

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

fs/iomap/direct-io.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#include <linux/iomap.h>
1212
#include <linux/backing-dev.h>
1313
#include <linux/uio.h>
14-
#include <linux/set_memory.h>
1514
#include <linux/task_io_accounting_ops.h>
1615
#include "trace.h"
1716

@@ -781,8 +780,6 @@ static int __init iomap_dio_init(void)
781780
if (!zero_page)
782781
return -ENOMEM;
783782

784-
set_memory_ro((unsigned long)page_address(zero_page),
785-
1U << IOMAP_ZERO_PAGE_ORDER);
786783
return 0;
787784
}
788785
fs_initcall(iomap_dio_init);

0 commit comments

Comments
 (0)