Skip to content

Commit d229290

Browse files
osctoberafaeljw
authored andcommitted
PM-runtime: add tracepoints for usage_count changes
Add tracepoints to remaining places where device's power.usage_count is changed. This helps debugging where and why autosuspend is prevented. Signed-off-by: Michał Mirosław <[email protected]> Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent b3a987b commit d229290

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

drivers/base/power/runtime.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1006,8 +1006,10 @@ int __pm_runtime_idle(struct device *dev, int rpmflags)
10061006
int retval;
10071007

10081008
if (rpmflags & RPM_GET_PUT) {
1009-
if (!atomic_dec_and_test(&dev->power.usage_count))
1009+
if (!atomic_dec_and_test(&dev->power.usage_count)) {
1010+
trace_rpm_usage_rcuidle(dev, rpmflags);
10101011
return 0;
1012+
}
10111013
}
10121014

10131015
might_sleep_if(!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe);
@@ -1038,8 +1040,10 @@ int __pm_runtime_suspend(struct device *dev, int rpmflags)
10381040
int retval;
10391041

10401042
if (rpmflags & RPM_GET_PUT) {
1041-
if (!atomic_dec_and_test(&dev->power.usage_count))
1043+
if (!atomic_dec_and_test(&dev->power.usage_count)) {
1044+
trace_rpm_usage_rcuidle(dev, rpmflags);
10421045
return 0;
1046+
}
10431047
}
10441048

10451049
might_sleep_if(!(rpmflags & RPM_ASYNC) && !dev->power.irq_safe);
@@ -1101,6 +1105,7 @@ int pm_runtime_get_if_in_use(struct device *dev)
11011105
retval = dev->power.disable_depth > 0 ? -EINVAL :
11021106
dev->power.runtime_status == RPM_ACTIVE
11031107
&& atomic_inc_not_zero(&dev->power.usage_count);
1108+
trace_rpm_usage_rcuidle(dev, 0);
11041109
spin_unlock_irqrestore(&dev->power.lock, flags);
11051110
return retval;
11061111
}
@@ -1434,6 +1439,8 @@ void pm_runtime_allow(struct device *dev)
14341439
dev->power.runtime_auto = true;
14351440
if (atomic_dec_and_test(&dev->power.usage_count))
14361441
rpm_idle(dev, RPM_AUTO | RPM_ASYNC);
1442+
else
1443+
trace_rpm_usage_rcuidle(dev, RPM_AUTO | RPM_ASYNC);
14371444

14381445
out:
14391446
spin_unlock_irq(&dev->power.lock);
@@ -1501,6 +1508,8 @@ static void update_autosuspend(struct device *dev, int old_delay, int old_use)
15011508
if (!old_use || old_delay >= 0) {
15021509
atomic_inc(&dev->power.usage_count);
15031510
rpm_resume(dev, 0);
1511+
} else {
1512+
trace_rpm_usage_rcuidle(dev, 0);
15041513
}
15051514
}
15061515

include/trace/events/rpm.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,12 @@ DEFINE_EVENT(rpm_internal, rpm_idle,
7474

7575
TP_ARGS(dev, flags)
7676
);
77+
DEFINE_EVENT(rpm_internal, rpm_usage,
78+
79+
TP_PROTO(struct device *dev, int flags),
80+
81+
TP_ARGS(dev, flags)
82+
);
7783

7884
TRACE_EVENT(rpm_return_int,
7985
TP_PROTO(struct device *dev, unsigned long ip, int ret),

0 commit comments

Comments
 (0)