Skip to content

Commit d280783

Browse files
linuswkuba-moo
authored andcommitted
net: xscale: Drop unused PHY number
For some cargoculted reason on incomplete cleanup, we have a PHY number which refers to nothing and gives confusing messages about PHY 0 on all ports. Print the name of the actual PHY device instead. Reported-by: Howard Harte <[email protected]> Signed-off-by: Linus Walleij <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 2b7ac0c commit d280783

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/ethernet/xscale/ixp4xx_eth.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ typedef void buffer_t;
163163

164164
/* Information about built-in Ethernet MAC interfaces */
165165
struct eth_plat_info {
166-
u8 phy; /* MII PHY ID, 0 - 31 */
167166
u8 rxq; /* configurable, currently 0 - 31 only */
168167
u8 txreadyq;
169168
u8 hwaddr[ETH_ALEN];
@@ -1583,7 +1582,7 @@ static int ixp4xx_eth_probe(struct platform_device *pdev)
15831582
if ((err = register_netdev(ndev)))
15841583
goto err_phy_dis;
15851584

1586-
netdev_info(ndev, "%s: MII PHY %i on %s\n", ndev->name, plat->phy,
1585+
netdev_info(ndev, "%s: MII PHY %s on %s\n", ndev->name, phydev_name(phydev),
15871586
npe_name(port->npe));
15881587

15891588
return 0;

0 commit comments

Comments
 (0)