Skip to content

Commit d29e0b2

Browse files
committed
lockdep: Complain only once about RCU in extended quiescent state
Currently, lockdep_rcu_suspicious() complains twice about RCU read-side critical sections being invoked from within extended quiescent states, for example: RCU used illegally from idle CPU! rcu_scheduler_active = 2, debug_locks = 1 RCU used illegally from extended quiescent state! This commit therefore saves a couple lines of code and one line of console-log output by eliminating the first of these two complaints. Link: https://lore.kernel.org/lkml/[email protected] Cc: Peter Zijlstra <[email protected]> Cc: Ingo Molnar <[email protected]> Cc: Will Deacon <[email protected]> Signed-off-by: Paul E. McKenney <[email protected]>
1 parent 04b25a4 commit d29e0b2

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

kernel/locking/lockdep.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5851,9 +5851,7 @@ void lockdep_rcu_suspicious(const char *file, const int line, const char *s)
58515851
pr_warn("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
58525852
!rcu_lockdep_current_cpu_online()
58535853
? "RCU used illegally from offline CPU!\n"
5854-
: !rcu_is_watching()
5855-
? "RCU used illegally from idle CPU!\n"
5856-
: "",
5854+
: "",
58575855
rcu_scheduler_active, debug_locks);
58585856

58595857
/*

0 commit comments

Comments
 (0)