Skip to content

Commit d2b366c

Browse files
dangowrtPaolo Abeni
authored andcommitted
net: phy: aquantia: fix setting active_low bit
phy_modify_mmd was used wrongly in aqr_phy_led_active_low_set() resulting in a no-op instead of setting the VEND1_GLOBAL_LED_DRIVE_VDD bit. Correctly set VEND1_GLOBAL_LED_DRIVE_VDD bit. Fixes: 61578f6 ("net: phy: aquantia: add support for PHY LEDs") Signed-off-by: Daniel Golle <[email protected]> Reviewed-by: Russell King (Oracle) <[email protected]> Link: https://patch.msgid.link/ab963584b0a7e3b4dac39472a4b82ca264d79630.1726580902.git.daniel@makrotopia.org Signed-off-by: Paolo Abeni <[email protected]>
1 parent f011b31 commit d2b366c

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/phy/aquantia/aquantia_leds.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ int aqr_phy_led_hw_control_set(struct phy_device *phydev, u8 index,
120120
int aqr_phy_led_active_low_set(struct phy_device *phydev, int index, bool enable)
121121
{
122122
return phy_modify_mmd(phydev, MDIO_MMD_VEND1, AQR_LED_DRIVE(index),
123-
VEND1_GLOBAL_LED_DRIVE_VDD, enable);
123+
VEND1_GLOBAL_LED_DRIVE_VDD,
124+
enable ? VEND1_GLOBAL_LED_DRIVE_VDD : 0);
124125
}
125126

126127
int aqr_phy_led_polarity_set(struct phy_device *phydev, int index, unsigned long modes)

0 commit comments

Comments
 (0)