Skip to content

Commit d2f79e6

Browse files
fdmananakdave
authored andcommitted
btrfs: remove redundant BUG_ON() from __btrfs_inc_extent_ref()
At __btrfs_inc_extent_ref() we are doing a BUG_ON() if we are dealing with a tree block reference that has a reference count that is different from 1, but we have already dealt with this case at run_delayed_tree_ref(), making it useless. So remove the BUG_ON(). Reviewed-by: Josef Bacik <[email protected]> Signed-off-by: Filipe Manana <[email protected]> Reviewed-by: David Sterba <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 1bf76df commit d2f79e6

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

fs/btrfs/extent-tree.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1514,15 +1514,14 @@ static int __btrfs_inc_extent_ref(struct btrfs_trans_handle *trans,
15141514
btrfs_release_path(path);
15151515

15161516
/* now insert the actual backref */
1517-
if (owner < BTRFS_FIRST_FREE_OBJECTID) {
1518-
BUG_ON(refs_to_add != 1);
1517+
if (owner < BTRFS_FIRST_FREE_OBJECTID)
15191518
ret = insert_tree_block_ref(trans, path, bytenr, parent,
15201519
root_objectid);
1521-
} else {
1520+
else
15221521
ret = insert_extent_data_ref(trans, path, bytenr, parent,
15231522
root_objectid, owner, offset,
15241523
refs_to_add);
1525-
}
1524+
15261525
if (ret)
15271526
btrfs_abort_transaction(trans, ret);
15281527
out:

0 commit comments

Comments
 (0)