Skip to content

Commit d2fab3f

Browse files
Sibi Sankarstorulf
authored andcommitted
mailbox: qcom-cpucp: Mark the irq with IRQF_NO_SUSPEND flag
The qcom-cpucp mailbox irq is expected to function during suspend-resume cycle particularly when the scmi cpufreq driver can query the current frequency using the get_level message after the cpus are brought up during resume. Hence mark the irq with IRQF_NO_SUSPEND flag to fix the do_xfer failures we see during resume. Err Logs: arm-scmi firmware:scmi: timed out in resp(caller:do_xfer+0x164/0x568) cpufreq: cpufreq_online: ->get() failed Reported-by: Johan Hovold <[email protected]> Closes: https://lore.kernel.org/lkml/[email protected]/ Fixes: 0e2a9a0 ("mailbox: Add support for QTI CPUCP mailbox controller") Signed-off-by: Sibi Sankar <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Tested-by: Johan Hovold <[email protected]> Cc: [email protected] Message-ID: <[email protected]> Signed-off-by: Ulf Hansson <[email protected]>
1 parent e2261bb commit d2fab3f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mailbox/qcom-cpucp-mbox.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ static int qcom_cpucp_mbox_probe(struct platform_device *pdev)
138138
return irq;
139139

140140
ret = devm_request_irq(dev, irq, qcom_cpucp_mbox_irq_fn,
141-
IRQF_TRIGGER_HIGH, "apss_cpucp_mbox", cpucp);
141+
IRQF_TRIGGER_HIGH | IRQF_NO_SUSPEND, "apss_cpucp_mbox", cpucp);
142142
if (ret < 0)
143143
return dev_err_probe(dev, ret, "Failed to register irq: %d\n", irq);
144144

0 commit comments

Comments
 (0)