Skip to content

Commit d2fc83c

Browse files
chuckleverAnna Schumaker
authored andcommitted
NFS: CB_OFFLOAD can return NFS4ERR_DELAY
RFC 7862 permits the callback service to respond to a CB_OFFLOAD operation with NFS4ERR_DELAY. Use that instead of NFS4ERR_SERVERFAULT for temporary memory allocation failure, as that is more consistent with how other operations report memory allocation failure. Reviewed-by: Jeff Layton <[email protected]> Signed-off-by: Chuck Lever <[email protected]> Reviewed-by: Benjamin Coddington <[email protected]> Signed-off-by: Anna Schumaker <[email protected]>
1 parent 90190ba commit d2fc83c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/nfs/callback_proc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -718,7 +718,7 @@ __be32 nfs4_callback_offload(void *data, void *dummy,
718718

719719
copy = kzalloc(sizeof(struct nfs4_copy_state), GFP_KERNEL);
720720
if (!copy)
721-
return htonl(NFS4ERR_SERVERFAULT);
721+
return cpu_to_be32(NFS4ERR_DELAY);
722722

723723
spin_lock(&cps->clp->cl_lock);
724724
rcu_read_lock();

0 commit comments

Comments
 (0)