Skip to content

Commit d324810

Browse files
committed
Merge tag 'for-linus-2019-11-21' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux
Pull pidfd fixlet from Christian Brauner: "This contains a simple fix for the pidfd poll method. In the original patchset pidfd_poll() was made to return an unsigned int. However, the poll method is defined to return a __poll_t. While the unsigned int is not a huge deal it's just nicer to return a __poll_t. I've decided to send it right before the 5.4 release mainly so that stable doesn't need to backport it to both 5.4 and 5.3" * tag 'for-linus-2019-11-21' of git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux: fork: fix pidfd_poll()'s return type
2 parents c74386d + 9e77716 commit d324810

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

kernel/fork.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1708,11 +1708,11 @@ static void pidfd_show_fdinfo(struct seq_file *m, struct file *f)
17081708
/*
17091709
* Poll support for process exit notification.
17101710
*/
1711-
static unsigned int pidfd_poll(struct file *file, struct poll_table_struct *pts)
1711+
static __poll_t pidfd_poll(struct file *file, struct poll_table_struct *pts)
17121712
{
17131713
struct task_struct *task;
17141714
struct pid *pid = file->private_data;
1715-
int poll_flags = 0;
1715+
__poll_t poll_flags = 0;
17161716

17171717
poll_wait(file, &pid->wait_pidfd, pts);
17181718

@@ -1724,7 +1724,7 @@ static unsigned int pidfd_poll(struct file *file, struct poll_table_struct *pts)
17241724
* group, then poll(2) should block, similar to the wait(2) family.
17251725
*/
17261726
if (!task || (task->exit_state && thread_group_empty(task)))
1727-
poll_flags = POLLIN | POLLRDNORM;
1727+
poll_flags = EPOLLIN | EPOLLRDNORM;
17281728
rcu_read_unlock();
17291729

17301730
return poll_flags;

0 commit comments

Comments
 (0)