Skip to content

Commit d341e9a

Browse files
mwilckmartinkpetersen
authored andcommitted
scsi: qla2xxx: fix rports not being mark as lost in sync fabric scan
In qla2x00_find_all_fabric_devs(), fcport->flags & FCF_LOGIN_NEEDED is a necessary condition for logging into new rports, but not for dropping lost ones. Fixes: 726b854 ("qla2xxx: Add framework for async fabric discovery") Link: https://lore.kernel.org/r/[email protected] Tested-by: David Bond <[email protected]> Signed-off-by: Martin Wilck <[email protected]> Acked-by: Himanshu Madhani <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 69b41f1 commit d341e9a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/scsi/qla2xxx/qla_init.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5898,8 +5898,7 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha)
58985898
if (test_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags))
58995899
break;
59005900

5901-
if ((fcport->flags & FCF_FABRIC_DEVICE) == 0 ||
5902-
(fcport->flags & FCF_LOGIN_NEEDED) == 0)
5901+
if ((fcport->flags & FCF_FABRIC_DEVICE) == 0)
59035902
continue;
59045903

59055904
if (fcport->scan_state == QLA_FCPORT_SCAN) {
@@ -5922,7 +5921,8 @@ qla2x00_find_all_fabric_devs(scsi_qla_host_t *vha)
59225921
}
59235922
}
59245923

5925-
if (fcport->scan_state == QLA_FCPORT_FOUND)
5924+
if (fcport->scan_state == QLA_FCPORT_FOUND &&
5925+
(fcport->flags & FCF_LOGIN_NEEDED) != 0)
59265926
qla24xx_fcport_handle_login(vha, fcport);
59275927
}
59285928
return (rval);

0 commit comments

Comments
 (0)