Skip to content

Commit d372ec9

Browse files
vsyrjalatursulin
authored andcommitted
drm/i915: Simplify intel_panel_add_edid_alt_fixed_modes()
Since commit a5810f5 ("drm/i915: Allow more varied alternate fixed modes for panels") intel_panel_add_edid_alt_fixed_modes() no longer considers vrr vs. drrs separately. So no reason to pass them as separate parameters either. Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jani Nikula <[email protected]> (cherry picked from commit eb89e83) Signed-off-by: Tvrtko Ursulin <[email protected]>
1 parent e797625 commit d372ec9

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5276,7 +5276,7 @@ static bool intel_edp_init_connector(struct intel_dp *intel_dp,
52765276
encoder->devdata, IS_ERR(edid) ? NULL : edid);
52775277

52785278
intel_panel_add_edid_fixed_modes(intel_connector,
5279-
intel_connector->panel.vbt.drrs_type != DRRS_TYPE_NONE,
5279+
intel_connector->panel.vbt.drrs_type != DRRS_TYPE_NONE ||
52805280
intel_vrr_is_capable(intel_connector));
52815281

52825282
/* MSO requires information from the EDID */

drivers/gpu/drm/i915/display/intel_lvds.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -972,8 +972,7 @@ void intel_lvds_init(struct drm_i915_private *dev_priv)
972972

973973
/* Try EDID first */
974974
intel_panel_add_edid_fixed_modes(intel_connector,
975-
intel_connector->panel.vbt.drrs_type != DRRS_TYPE_NONE,
976-
false);
975+
intel_connector->panel.vbt.drrs_type != DRRS_TYPE_NONE);
977976

978977
/* Failed to get EDID, what about VBT? */
979978
if (!intel_panel_preferred_fixed_mode(intel_connector))

drivers/gpu/drm/i915/display/intel_panel.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,10 @@ static void intel_panel_destroy_probed_modes(struct intel_connector *connector)
254254
}
255255

256256
void intel_panel_add_edid_fixed_modes(struct intel_connector *connector,
257-
bool has_drrs, bool has_vrr)
257+
bool use_alt_fixed_modes)
258258
{
259259
intel_panel_add_edid_preferred_mode(connector);
260-
if (intel_panel_preferred_fixed_mode(connector) && (has_drrs || has_vrr))
260+
if (intel_panel_preferred_fixed_mode(connector) && use_alt_fixed_modes)
261261
intel_panel_add_edid_alt_fixed_modes(connector);
262262
intel_panel_destroy_probed_modes(connector);
263263
}

drivers/gpu/drm/i915/display/intel_panel.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ int intel_panel_fitting(struct intel_crtc_state *crtc_state,
4444
int intel_panel_compute_config(struct intel_connector *connector,
4545
struct drm_display_mode *adjusted_mode);
4646
void intel_panel_add_edid_fixed_modes(struct intel_connector *connector,
47-
bool has_drrs, bool has_vrr);
47+
bool use_alt_fixed_modes);
4848
void intel_panel_add_vbt_lfp_fixed_mode(struct intel_connector *connector);
4949
void intel_panel_add_vbt_sdvo_fixed_mode(struct intel_connector *connector);
5050
void intel_panel_add_encoder_fixed_mode(struct intel_connector *connector,

drivers/gpu/drm/i915/display/intel_sdvo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2901,7 +2901,7 @@ intel_sdvo_lvds_init(struct intel_sdvo *intel_sdvo, int device)
29012901

29022902
if (!intel_panel_preferred_fixed_mode(intel_connector)) {
29032903
intel_ddc_get_modes(connector, &intel_sdvo->ddc);
2904-
intel_panel_add_edid_fixed_modes(intel_connector, false, false);
2904+
intel_panel_add_edid_fixed_modes(intel_connector, false);
29052905
}
29062906

29072907
intel_panel_init(intel_connector);

0 commit comments

Comments
 (0)