Skip to content

Commit d3a450a

Browse files
Leon Huangalexdeucher
authored andcommitted
drm/amd/display: Refactor HPD IRQ error checking flow
[Why] HPD error status does not cover Replay desync error status while executing autotests and CTS tests. [How] Refactor the checking flow, reporting the HPD error based on different eDP feature. Reviewed-by: Robin Chen <[email protected]> Signed-off-by: Leon Huang <[email protected]> Signed-off-by: Hamza Mahfooz <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent dfb214e commit d3a450a

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -221,21 +221,11 @@ static void handle_hpd_irq_replay_sink(struct dc_link *link)
221221
&replay_error_status.raw,
222222
sizeof(replay_error_status.raw));
223223

224-
link->replay_settings.config.replay_error_status.bits.LINK_CRC_ERROR =
225-
replay_error_status.bits.LINK_CRC_ERROR;
226-
link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR =
227-
replay_configuration.bits.DESYNC_ERROR_STATUS;
228-
link->replay_settings.config.replay_error_status.bits.STATE_TRANSITION_ERROR =
229-
replay_configuration.bits.STATE_TRANSITION_ERROR_STATUS;
230-
231-
if (link->replay_settings.config.replay_error_status.bits.LINK_CRC_ERROR ||
232-
link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR ||
233-
link->replay_settings.config.replay_error_status.bits.STATE_TRANSITION_ERROR) {
224+
if (replay_error_status.bits.LINK_CRC_ERROR ||
225+
replay_configuration.bits.DESYNC_ERROR_STATUS ||
226+
replay_configuration.bits.STATE_TRANSITION_ERROR_STATUS) {
234227
bool allow_active;
235228

236-
if (link->replay_settings.config.replay_error_status.bits.DESYNC_ERROR)
237-
link->replay_settings.config.received_desync_error_hpd = 1;
238-
239229
if (link->replay_settings.config.force_disable_desync_error_check)
240230
return;
241231

0 commit comments

Comments
 (0)