Skip to content

Commit d4293f9

Browse files
Konstantin Taranovrleon
authored andcommitted
RDMA/mana_ib: unify mana_ib functions to support any gdma device
Use the installed gdma_device instead of hard-coded device in requests to the HW. Signed-off-by: Konstantin Taranov <[email protected]> Link: https://patch.msgid.link/[email protected] Reviewed-by: Long Li <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent c390828 commit d4293f9

File tree

3 files changed

+16
-20
lines changed

3 files changed

+16
-20
lines changed

drivers/infiniband/hw/mana/cq.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,12 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,
1515
struct ib_device *ibdev = ibcq->device;
1616
struct mana_ib_create_cq ucmd = {};
1717
struct mana_ib_dev *mdev;
18-
struct gdma_context *gc;
1918
bool is_rnic_cq;
2019
u32 doorbell;
2120
u32 buf_size;
2221
int err;
2322

2423
mdev = container_of(ibdev, struct mana_ib_dev, ib_dev);
25-
gc = mdev_to_gc(mdev);
2624

2725
cq->comp_vector = attr->comp_vector % ibdev->num_comp_vectors;
2826
cq->cq_handle = INVALID_MANA_HANDLE;
@@ -65,7 +63,7 @@ int mana_ib_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,
6563
ibdev_dbg(ibdev, "Failed to create kernel queue for create cq, %d\n", err);
6664
return err;
6765
}
68-
doorbell = gc->mana_ib.doorbell;
66+
doorbell = mdev->gdma_dev->doorbell;
6967
}
7068

7169
if (is_rnic_cq) {

drivers/infiniband/hw/mana/main.c

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ void mana_ib_dealloc_ucontext(struct ib_ucontext *ibcontext)
244244
int mana_ib_create_kernel_queue(struct mana_ib_dev *mdev, u32 size, enum gdma_queue_type type,
245245
struct mana_ib_queue *queue)
246246
{
247-
struct gdma_context *gc = mdev_to_gc(mdev);
248247
struct gdma_queue_spec spec = {};
249248
int err;
250249

@@ -253,7 +252,7 @@ int mana_ib_create_kernel_queue(struct mana_ib_dev *mdev, u32 size, enum gdma_qu
253252
spec.type = type;
254253
spec.monitor_avl_buf = false;
255254
spec.queue_size = size;
256-
err = mana_gd_create_mana_wq_cq(&gc->mana_ib, &spec, &queue->kmem);
255+
err = mana_gd_create_mana_wq_cq(mdev->gdma_dev, &spec, &queue->kmem);
257256
if (err)
258257
return err;
259258
/* take ownership into mana_ib from mana */
@@ -784,7 +783,7 @@ int mana_ib_create_eqs(struct mana_ib_dev *mdev)
784783
spec.eq.log2_throttle_limit = LOG2_EQ_THROTTLE;
785784
spec.eq.msix_index = 0;
786785

787-
err = mana_gd_create_mana_eq(&gc->mana_ib, &spec, &mdev->fatal_err_eq);
786+
err = mana_gd_create_mana_eq(mdev->gdma_dev, &spec, &mdev->fatal_err_eq);
788787
if (err)
789788
return err;
790789

@@ -835,7 +834,7 @@ int mana_ib_gd_create_rnic_adapter(struct mana_ib_dev *mdev)
835834

836835
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CREATE_ADAPTER, sizeof(req), sizeof(resp));
837836
req.hdr.req.msg_version = GDMA_MESSAGE_V2;
838-
req.hdr.dev_id = gc->mana_ib.dev_id;
837+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
839838
req.notify_eq_id = mdev->fatal_err_eq->id;
840839

841840
if (mdev->adapter_caps.feature_flags & MANA_IB_FEATURE_CLIENT_ERROR_CQE_SUPPORT)
@@ -860,7 +859,7 @@ int mana_ib_gd_destroy_rnic_adapter(struct mana_ib_dev *mdev)
860859

861860
gc = mdev_to_gc(mdev);
862861
mana_gd_init_req_hdr(&req.hdr, MANA_IB_DESTROY_ADAPTER, sizeof(req), sizeof(resp));
863-
req.hdr.dev_id = gc->mana_ib.dev_id;
862+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
864863
req.adapter = mdev->adapter_handle;
865864

866865
err = mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp);
@@ -887,7 +886,7 @@ int mana_ib_gd_add_gid(const struct ib_gid_attr *attr, void **context)
887886
}
888887

889888
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CONFIG_IP_ADDR, sizeof(req), sizeof(resp));
890-
req.hdr.dev_id = gc->mana_ib.dev_id;
889+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
891890
req.adapter = mdev->adapter_handle;
892891
req.op = ADDR_OP_ADD;
893892
req.sgid_type = (ntype == RDMA_NETWORK_IPV6) ? SGID_TYPE_IPV6 : SGID_TYPE_IPV4;
@@ -917,7 +916,7 @@ int mana_ib_gd_del_gid(const struct ib_gid_attr *attr, void **context)
917916
}
918917

919918
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CONFIG_IP_ADDR, sizeof(req), sizeof(resp));
920-
req.hdr.dev_id = gc->mana_ib.dev_id;
919+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
921920
req.adapter = mdev->adapter_handle;
922921
req.op = ADDR_OP_REMOVE;
923922
req.sgid_type = (ntype == RDMA_NETWORK_IPV6) ? SGID_TYPE_IPV6 : SGID_TYPE_IPV4;
@@ -940,7 +939,7 @@ int mana_ib_gd_config_mac(struct mana_ib_dev *mdev, enum mana_ib_addr_op op, u8
940939
int err;
941940

942941
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CONFIG_MAC_ADDR, sizeof(req), sizeof(resp));
943-
req.hdr.dev_id = gc->mana_ib.dev_id;
942+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
944943
req.adapter = mdev->adapter_handle;
945944
req.op = op;
946945
copy_in_reverse(req.mac_addr, mac, ETH_ALEN);
@@ -965,7 +964,7 @@ int mana_ib_gd_create_cq(struct mana_ib_dev *mdev, struct mana_ib_cq *cq, u32 do
965964
return -EINVAL;
966965

967966
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CREATE_CQ, sizeof(req), sizeof(resp));
968-
req.hdr.dev_id = gc->mana_ib.dev_id;
967+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
969968
req.adapter = mdev->adapter_handle;
970969
req.gdma_region = cq->queue.gdma_region;
971970
req.eq_id = mdev->eqs[cq->comp_vector]->id;
@@ -997,7 +996,7 @@ int mana_ib_gd_destroy_cq(struct mana_ib_dev *mdev, struct mana_ib_cq *cq)
997996
return 0;
998997

999998
mana_gd_init_req_hdr(&req.hdr, MANA_IB_DESTROY_CQ, sizeof(req), sizeof(resp));
1000-
req.hdr.dev_id = gc->mana_ib.dev_id;
999+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
10011000
req.adapter = mdev->adapter_handle;
10021001
req.cq_handle = cq->cq_handle;
10031002

@@ -1023,7 +1022,7 @@ int mana_ib_gd_create_rc_qp(struct mana_ib_dev *mdev, struct mana_ib_qp *qp,
10231022
int err, i;
10241023

10251024
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CREATE_RC_QP, sizeof(req), sizeof(resp));
1026-
req.hdr.dev_id = gc->mana_ib.dev_id;
1025+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
10271026
req.adapter = mdev->adapter_handle;
10281027
req.pd_handle = pd->pd_handle;
10291028
req.send_cq_handle = send_cq->cq_handle;
@@ -1059,7 +1058,7 @@ int mana_ib_gd_destroy_rc_qp(struct mana_ib_dev *mdev, struct mana_ib_qp *qp)
10591058
int err;
10601059

10611060
mana_gd_init_req_hdr(&req.hdr, MANA_IB_DESTROY_RC_QP, sizeof(req), sizeof(resp));
1062-
req.hdr.dev_id = gc->mana_ib.dev_id;
1061+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
10631062
req.adapter = mdev->adapter_handle;
10641063
req.rc_qp_handle = qp->qp_handle;
10651064
err = mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp);
@@ -1082,7 +1081,7 @@ int mana_ib_gd_create_ud_qp(struct mana_ib_dev *mdev, struct mana_ib_qp *qp,
10821081
int err, i;
10831082

10841083
mana_gd_init_req_hdr(&req.hdr, MANA_IB_CREATE_UD_QP, sizeof(req), sizeof(resp));
1085-
req.hdr.dev_id = gc->mana_ib.dev_id;
1084+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
10861085
req.adapter = mdev->adapter_handle;
10871086
req.pd_handle = pd->pd_handle;
10881087
req.send_cq_handle = send_cq->cq_handle;
@@ -1117,7 +1116,7 @@ int mana_ib_gd_destroy_ud_qp(struct mana_ib_dev *mdev, struct mana_ib_qp *qp)
11171116
int err;
11181117

11191118
mana_gd_init_req_hdr(&req.hdr, MANA_IB_DESTROY_UD_QP, sizeof(req), sizeof(resp));
1120-
req.hdr.dev_id = gc->mana_ib.dev_id;
1119+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
11211120
req.adapter = mdev->adapter_handle;
11221121
req.qp_handle = qp->qp_handle;
11231122
err = mana_gd_send_request(gc, sizeof(req), &req, sizeof(resp), &resp);

drivers/infiniband/hw/mana/qp.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,6 @@ static int mana_ib_create_ud_qp(struct ib_qp *ibqp, struct ib_pd *ibpd,
635635
{
636636
struct mana_ib_dev *mdev = container_of(ibpd->device, struct mana_ib_dev, ib_dev);
637637
struct mana_ib_qp *qp = container_of(ibqp, struct mana_ib_qp, ibqp);
638-
struct gdma_context *gc = mdev_to_gc(mdev);
639638
u32 doorbell, queue_size;
640639
int i, err;
641640

@@ -654,7 +653,7 @@ static int mana_ib_create_ud_qp(struct ib_qp *ibqp, struct ib_pd *ibpd,
654653
goto destroy_queues;
655654
}
656655
}
657-
doorbell = gc->mana_ib.doorbell;
656+
doorbell = mdev->gdma_dev->doorbell;
658657

659658
err = create_shadow_queue(&qp->shadow_rq, attr->cap.max_recv_wr,
660659
sizeof(struct ud_rq_shadow_wqe));
@@ -736,7 +735,7 @@ static int mana_ib_gd_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
736735
int err;
737736

738737
mana_gd_init_req_hdr(&req.hdr, MANA_IB_SET_QP_STATE, sizeof(req), sizeof(resp));
739-
req.hdr.dev_id = gc->mana_ib.dev_id;
738+
req.hdr.dev_id = mdev->gdma_dev->dev_id;
740739
req.adapter = mdev->adapter_handle;
741740
req.qp_handle = qp->qp_handle;
742741
req.qp_state = attr->qp_state;

0 commit comments

Comments
 (0)