Skip to content

Commit d4cad41

Browse files
committed
firewire: ohci: replace request_irq() with request_threaded_irq()
Nowadays request_irq() is a wrapper of request_threaded_irq(). The IRQ handler of 1394 ohci driver has never been optimized yet, while it is a good preparation for the future work to replace the latter. This commit replaces the former. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Sakamoto <[email protected]>
1 parent fb7d0e5 commit d4cad41

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/firewire/ohci.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3758,11 +3758,11 @@ static int pci_probe(struct pci_dev *dev,
37583758

37593759
if (!(ohci->quirks & QUIRK_NO_MSI))
37603760
pci_enable_msi(dev);
3761-
if (request_irq(dev->irq, irq_handler,
3762-
pci_dev_msi_enabled(dev) ? 0 : IRQF_SHARED,
3763-
ohci_driver_name, ohci)) {
3761+
err = request_threaded_irq(dev->irq, irq_handler, NULL,
3762+
pci_dev_msi_enabled(dev) ? 0 : IRQF_SHARED, ohci_driver_name,
3763+
ohci);
3764+
if (err < 0) {
37643765
ohci_err(ohci, "failed to allocate interrupt %d\n", dev->irq);
3765-
err = -EIO;
37663766
goto fail_msi;
37673767
}
37683768

0 commit comments

Comments
 (0)